Skip to content

Adding ops without e2e support #887

@henrytwo

Description

@henrytwo

Hi @silvasean, we're now able to trace a Huggingface BERT model with full forward and backwards graph, but we had to add support for a few ops to torch-mlir.

Looking at some existing PRs (e.g. #570) it seems that adding support for an op usually comes with type refinement, lowering to linalg, and e2e tests (and the e2e tests won't work without the type refinement).

Since we don't need any of this other stuff for LTC, would a PR with only updates to torch_ods_gen.py and GeneratedAtenOps.td be acceptable?

cc: @antoniojkim @ke1337

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions