[dynamo] Verify the default value is passed by kwargs (#2998)

llvm · Apr 27, 2024 · 4fbe77a · 4fbe77a
1 parent f173a06
commit 4fbe77a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/projects/pt1/e2e_testing/xfail_sets.py b/projects/pt1/e2e_testing/xfail_sets.py
@@ -252,18 +252,14 @@
     # ERROR: Exception: Unsupported: missing default value for argument 0 in schema for aten.div.Tensor_mode
     "ElementwiseAtenFloorDivideScalarNegativeModule_basic",
     "ElementwiseAtenFloorDivideScalarModule_basic",
-    "ElementwiseDivTensorRoundingModeFloorModule_basic",
-    "ElementwiseDivTensorRoundingModeTruncModule_basic",
-    "ElementwiseDivTensorRoundingModeFloorStaticModule_basic",
-    "ElementwiseDivTensorRoundingModeTruncStaticModule_basic",
-    "ElementwiseDivTensorRoundingModeFloorIntStaticModule_basic",
-    "ElementwiseDivTensorRoundingModeTruncIntStaticModule_basic",
     "ElementwiseDivScalarRoundingModeFloorModule_basic",
     "ElementwiseDivScalarRoundingModeTruncModule_basic",
     "ElementwiseDivScalarRoundingModeFloorStaticModule_basic",
     "ElementwiseDivScalarRoundingModeTruncStaticModule_basic",
     "ElementwiseDivScalarRoundingModeFloorIntStaticModule_basic",
     "ElementwiseDivScalarRoundingModeTruncIntStaticModule_basic",
+
+    # ERROR: 'torch.aten.mul.Tensor' op operand #1 must be Any Torch tensor type, but got '!torch.int'
     "AdaptiveAvgPool1dStaticLargerOutput_basic",
     "AdaptiveAvgPool1dGeneralDynamic_basic",
     "AdaptiveAvgPool1dGeneralDynamicNoBatches_basic",
@@ -276,10 +272,6 @@
     "TensorFloatModule_basic",
     "TensorIntModule_basic",
 
-    # ERROR: Exception: Unsupported: missing default value for argument 0 in schema for aten.randn.generator
-    "RandnGeneratorF64Module_basic",
-    "RandnGeneratorModule_basic",
-
     # START tests failing due to: complex floating point ops
     # END tests failing due to: complex floating point ops
 
@@ -343,8 +335,10 @@
     "IntImplicitModule_basic",
 
     # Others
+    "ExponentialModule_basic",
     "GridSamplerBasic1_basic",
     "GridSamplerBasic2_basic",
+    "GridSamplerBasic3_basic",
     "FakeQuantizePerTensorAffineModule_basic",
     "FakeQuantizePerTensorAffineDynamicShapeModule_basic",
     "FakeQuantizePerTensorAffineRoundToEvenModule_basic",

diff --git a/projects/pt1/python/torch_mlir/_dynamo_fx_importer.py b/projects/pt1/python/torch_mlir/_dynamo_fx_importer.py
@@ -78,7 +78,7 @@ def _check_meta_val(node):
                     assert len(node.args) < len(node.target._schema.arguments)
                     for i, argument in enumerate(
                             node.target._schema.arguments[len(node.args):]):
-                        if not argument.has_default_value():
+                        if not argument.has_default_value() and argument.name not in node.kwargs:
                             raise Exception(
                                 f"Unsupported: missing default value for argument {i} in schema for {node.target}"
                             )