[Offload] Add support for Mipmapped Textures#708
Merged
Conversation
This commit extends the offload-test-suite infrastructure to support textures with multiple mip levels. - Update OutputProperties to include MipLevels. - Update Vulkan backend to correctly create, upload, and sample from multi-mip images. - Add error checking in the DirectX and Vulkan backends to validate texture dimensions and mip counts. - Add docs/MipMappedTextures.md to explain the required data layout. Comprehensive tests were added for Texture2D functions, including sampling, gradients, and LOD calculation. Existing tests were updated to reflect correct results under the new infrastructure. Note: Multiple mip levels are currently restricted in the DirectX backend via runtime error checking. Fixes llvm#690 Assisted-by: Gemini
luciechoi
approved these changes
Feb 5, 2026
Keenuts
reviewed
Feb 13, 2026
Contributor
Keenuts
left a comment
Keenuts
left a comment
There was a problem hiding this comment.
LGTM, just a suggestion to improve usability
Keenuts
approved these changes
Feb 19, 2026
Contributor
|
This PR broke the tests introduced by #648 log: https://github.com/llvm/offload-test-suite/actions/runs/22190060194/job/64174939577#step:12:439 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extends the offload-test-suite infrastructure to support
textures with multiple mip levels.
multi-mip images.
texture dimensions and mip counts.
Comprehensive tests were added for Texture2D functions, including sampling,
gradients, and LOD calculation. Existing tests were updated to reflect
correct results under the new infrastructure.
Note: Multiple mip levels are currently restricted in the DirectX backend
via runtime error checking.
Fixes #690
Assisted-by: Gemini