[BOLT] Increase nfc-test coverage #467
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR triggers in-tree tests for additional source changes. Running out-of-tree tests is not needed. The main motivation is to cover patches Once merged, any changes to I've verified these internally and got expected behaviour in the below patches:
|
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/set-nfc-tests-once
branch
from
b03cc23 to
9ffb74e
Compare
Use `--check-bolt-sources` from nfc-check-setup.py to run tests when source files change between the current and previous revisions. This triggers only in-tree tests. When the llvm-bolt binary changes, both in-tree and out-of-tree tests are run.
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/increase-test-coverage
branch
from
8f4aaf1 to
326abf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
--check-bolt-sourcesfrom nfc-check-setup.py to run tests when source files change between the current and previous revisions.This triggers only in-tree tests. When the llvm-bolt binary changes, both in-tree and out-of-tree tests are run.