Skip to content

[BOLT] Excluding GNU build-id and cleanup. #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: users/paschalis-mpeis/bolt-nfc-check-validation
Choose a base branch
from

Conversation

paschalis-mpeis
Copy link
Member

Pass '--build-id' to the linker to disable emission of a unique build ID into a note section. This breaks nfc-mode tests.

Additional cleanup:

  • Out-of-tree tests are now labeled as 'BOLT large tests'
  • Dropped step 'nfc-stat-check' as it was disabled
  • Removed unused flags for Non-NFC tests

@paschalis-mpeis paschalis-mpeis marked this pull request as ready for review June 10, 2025 15:05
@paschalis-mpeis paschalis-mpeis requested a review from aaupov June 10, 2025 15:06
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/bolt-nfc-check-validation branch from 86e9c12 to 94d5651 Compare June 12, 2025 13:59
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/bolt-nfc-check-validation branch from 94d5651 to 55a3b78 Compare June 13, 2025 09:29
paschalis-mpeis and others added 2 commits June 13, 2025 10:32
Pass '--build-id' to the linker to disable emission of a unique
build ID into a note section. This breaks nfc-mode tests.

Additional cleanup:
- Out-of-tree tests are now labeled as 'BOLT large tests'
- Dropped step 'nfc-stat-check' as it was disabled
- Removed unused flags for Non-NFC tests
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/gnu-buildid-and-cleanup branch from cdd7fc9 to cf41ec9 Compare June 13, 2025 09:39
@paschalis-mpeis
Copy link
Member Author

Forced push to rebase on the PR stack. Also addressed comments.

@paschalis-mpeis paschalis-mpeis requested a review from aaupov June 13, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants