[BOLT] Add nfc-check-validation step #462
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/drop-meta-bolt-buildbot-aarch64
branch
from
a8f7936 to
c9403e5
Compare
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/bolt-nfc-check-validation
branch
from
072b153 to
93d801d
Compare
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/drop-meta-bolt-buildbot-aarch64
branch
from
c9403e5 to
d9f62ef
Compare
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/bolt-nfc-check-validation
branch
from
86e9c12 to
94d5651
Compare
|
Forced push to rebase, as base branch now renames the existing Meta buildbots instead of dropping them. |
aaupov
approved these changes
Jun 13, 2025
NFC-mode runs in-tree and out-of-tree (large BOLT tests) when there are changes affecting llvm-bolt between the current revision and the previous one. However, the revision SHA itself and the GNU build-id may be two unique differences when doing such a comparison. This patch introduces a lightweight sanity check step that reports a warning on the Buildbot so that we are aware when this occurs.
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/bolt-nfc-check-validation
branch
from
94d5651 to
55a3b78
Compare
|
(forced push to rebase on the parent branch. no other changes here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFC-mode runs in-tree and out-of-tree (large BOLT tests) when there are changes
affecting llvm-bolt between the current revision and the previous one.
However, the revision SHA itself and the GNU build-id may be two unique
differences when doing such a comparison.
This patch introduces a lightweight sanity check step that reports a warning on
the Buildbot so that we are aware when this occurs.