Skip to content

[BOLT] Rename Meta's Aarch64 workers and builders #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

paschalis-mpeis
Copy link
Member

No description provided.

@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/drop-meta-bolt-buildbot-aarch64 branch from a8f7936 to c9403e5 Compare June 6, 2025 12:23
@paschalis-mpeis paschalis-mpeis changed the title Drop Meta's Aarch64 BOLT configuration [BOLT] Drop Meta's Aarch64 configuration Jun 6, 2025
@paschalis-mpeis paschalis-mpeis marked this pull request as ready for review June 10, 2025 14:23
@paschalis-mpeis
Copy link
Member Author

This Buildbot is no longer maintained. We are coordinating with Meta on this. Our intention is to eventually replace it with an Arm-managed Buildbot (see discourse post).

@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/drop-meta-bolt-buildbot-aarch64 branch from c9403e5 to d9f62ef Compare June 12, 2025 07:50
@paschalis-mpeis paschalis-mpeis changed the title [BOLT] Drop Meta's Aarch64 configuration [BOLT] Rename Meta's Aarch64 workers and builders Jun 12, 2025
@paschalis-mpeis
Copy link
Member Author

Discussed with @aaupov and agreed to keep current AArch64 buildbot for now.
We'll investigate the regressions currently shown by builders/128 at a later stage and decide whether to keep it or not.

Just adding that the upcoming buildbot runs on Ubuntu 24.04.2 LTS (6.8.0-1029-aws) without regressions.

Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @gkistanova needs to update the workers file

@paschalis-mpeis
Copy link
Member Author

Thanks Amir.

I've sent another patch to align with the below excerpt from the guide. Those folders are on the workers, but I'm not sure if the master uses them too. Either way, it's also more aligned with the builder's name.

Please make sure your builder name and its builddir are unique through the file.

Regarding the below:

@gkistanova needs to update the workers file

Is this a manual step that happens when the workers are updated?
And are there any further comments from @gkistanova, or should I merge?

@DavidSpickett
Copy link
Contributor

This is a manual step. The new worker names need to exist in the database, otherwise they won't be allowed to connect (and repeated attempts to do so will get you IP banned, which needs to be manually removed too).

So wait for Galina to confirm what needs to be done here.

@paschalis-mpeis
Copy link
Member Author

Okay. Thanks a lot for the info David.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants