[Microbenchmarks] Add benchmarks for non-speculatable conditional scalar assignment autovec #331
+120
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar assignment autovec This adds more conditional scalar assignment benchmarks for cases where the assignment can't be speculated (resulting in an extra block + phis rather than selects in the IR). This patch also reworks the macros to make adding new test cases easier and less repetitive.
fhahn
reviewed
Feb 1, 2026
Comment on lines
+33
to
+35
| _Pragma("clang loop vectorize(disable) interleave(disable)") \ | ||
| \ | ||
| for (unsigned i = 0; i < ITERATIONS; i++) body; \ |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| _Pragma("clang loop vectorize(disable) interleave(disable)") \ | |
| \ | |
| for (unsigned i = 0; i < ITERATIONS; i++) body; \ | |
| _Pragma("clang loop vectorize(disable) interleave(disable)") \ | |
| for (unsigned i = 0; i < ITERATIONS; i++) body; \ |
Member
Author
There was a problem hiding this comment.
I added that newline as clang-format wants to do:
_Pragma( \
"clang loop vectorize(disable) interleave(disable)") for (unsigned i = \
0; \
i < \
ITERATIONS; \
i++) body; \without it.
Comment on lines
+47
to
+50
| DEF_SINGLE_CSA_LOOP(single_csa_only, LOOP_BLOCK({ | ||
| if (A[i] > Threshold) | ||
| Result = A[i]; | ||
| })); |
Contributor
There was a problem hiding this comment.
Would it add much more code if we pass the whole loop to the macro instead? That would make it easier to see what is actually benchmarked.
Member
Author
There was a problem hiding this comment.
not really, but it's harder to pass to a macro in a way that won't be badly formatted (so needs clang-format off/on). Since you can't wrap the for {} in a block (as the pragma must be directly placed before the for statement).
That's why I added LOOP_BLOCK() as a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more conditional scalar assignment benchmarks for cases where the assignment can't be speculated (resulting in an extra block + phis rather than selects in the IR).
This patch also reworks the macros to make adding new test cases easier and less repetitive.