[Fortran] Respect NO_STOP_MESSAGE if it is set in the environment #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests, particularly the NIST tests require NO_STOP_MESSAGE=1 to be set. This was done unconditionally in Fortran/lit.local.cfg. However, if the test suite is configured to run ONLY the NIST tests, for instance by setting `-DTEST_SUITE_SUBDIRS=Fortran/UnitTests/fcvs21_f95`, Fortran/lit.local.cfg is not processed and the tests fail. lit also ignores the variable even if it is explicitly set by the user. This commit addresses the issue and by ensuring that NO_STOP_MESSAGE is added to the environment used when running the tests. Also, NO_STOP_MESSAGE is no longer set unconditionally. If a value was explicitly provided by the user, it will be respected. If no value is provided, it will be set to 1 unconditionally. The README has been substantially expanded to provide more details about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests, particularly the NIST tests require NO_STOP_MESSAGE=1 to be set. This was done unconditionally in Fortran/lit.local.cfg. However, if the test suite is configured to run ONLY the NIST tests, for instance by setting
-DTEST_SUITE_SUBDIRS=Fortran/UnitTests/fcvs21_f95, Fortran/lit.local.cfg is not processed and the tests fail. lit also ignores the variable even if it is explicitly set by the user.This commit addresses the issue and by ensuring that NO_STOP_MESSAGE is added to the environment used when running the tests. Also, NO_STOP_MESSAGE is no longer set unconditionally. If a value was explicitly provided by the user, it will be respected. If no value is provided, it will be set to 1 unconditionally. The README has been substantially expanded to provide more details about this.