[flang] Disable invalid PUBLIC/PRIVATE pre-F2018 test #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch disables a test which is the old access-spec functionality.
A recent flang patch enforces PUBLIC and PRIVATE accessibility as defined
starting in F2018, and passed initially as paper J3/13-327r3;
the description is from "Whats New In Fortran 2018" by John Reid:
If a module A uses module B, the default accessibility for entities
it accesses from B is that of A. Specifying another accessibility
for each entity is awkward and error prone. It is now possible
for the name of a module to be included in the list of names of entities
made public or private on a public or private statement.
This sets the default for all entities accessed from that module.
In the F2023 standard, this is clause 8.6.1(1).
Author
|
I don't have merge permissions yet, so merge this whenever you can please; Flang PR 177596 will go in sometime. |
Contributor
|
I'll keep an eye on #177596. I'll merge this when that is approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch disables a test of the old access-spec functionality.
A recent flang PR enforces PUBLIC and PRIVATE accessibility as defined starting in F2018, and passed initially as paper J3/13-327r3; the description is from "Whats New In Fortran 2018" by John Reid:
In the F2023 standard, this is clause 8.6.1(1).
Related Flang PR: llvm/llvm-project#177596