[PS5] Adopt new compiler-rt naming scheme for the profile library. #99862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: None (goussepi) ChangesChanges the driver to look for libclang_rt.profile_nosubmission.a instead of libclang_rt.profile-x86_64_nosubmission.a Full diff: https://github.com/llvm/llvm-project/pull/99862.diff 2 Files Affected:
diff --git a/clang/lib/Driver/ToolChains/PS4CPU.h b/clang/lib/Driver/ToolChains/PS4CPU.h
index fee80e77462f3..b248d1c256129 100644
--- a/clang/lib/Driver/ToolChains/PS4CPU.h
+++ b/clang/lib/Driver/ToolChains/PS4CPU.h
@@ -163,7 +163,7 @@ class LLVM_LIBRARY_VISIBILITY PS5CPU : public PS4PS5Base {
llvm::opt::ArgStringList &CmdArgs, const char *Prefix,
const char *Suffix) const override;
const char *getProfileRTLibName() const override {
- return "libclang_rt.profile-x86_64_nosubmission.a";
+ return "libclang_rt.profile_nosubmission.a";
}
protected:
diff --git a/clang/test/Driver/ps4-ps5-runtime-flags.c b/clang/test/Driver/ps4-ps5-runtime-flags.c
index e75ba97948d23..4b00aead6fe5c 100644
--- a/clang/test/Driver/ps4-ps5-runtime-flags.c
+++ b/clang/test/Driver/ps4-ps5-runtime-flags.c
@@ -40,5 +40,5 @@
// RUN: %clang -target x86_64-sie-ps5 -fcs-profile-generate %s -### 2>&1 | FileCheck --check-prefix=CHECK-PS5-PROFILE %s
// RUN: %clang -target x86_64-sie-ps5 -fcs-profile-generate -fno-profile-generate %s -### 2>&1 | FileCheck --check-prefix=CHECK-PS5-NO-PROFILE %s
//
-// CHECK-PS5-PROFILE: "--dependent-lib=libclang_rt.profile-x86_64_nosubmission.a"
-// CHECK-PS5-NO-PROFILE-NOT: "--dependent-lib=libclang_rt.profile-x86_64_nosubmission.a"
+// CHECK-PS5-PROFILE: "--dependent-lib=libclang_rt.profile_nosubmission.a"
+// CHECK-PS5-NO-PROFILE-NOT: "--dependent-lib=libclang_rt.profile_nosubmission.a"
|
MaskRay
approved these changes
Jul 22, 2024
Changes the driver to look for libclang_rt.profile_nosubmission.a instead of libclang_rt.profile-x86_64_nosubmission.a
goussepi
force-pushed
the
lib-profile-new-naming-scheme
branch
from
8e2d203 to
f2bbdbd
Compare
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
…99862) Summary: Changes the driver to look for libclang_rt.profile_nosubmission.a instead of libclang_rt.profile-x86_64_nosubmission.a Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the driver to look for libclang_rt.profile_nosubmission.a instead of libclang_rt.profile-x86_64_nosubmission.a