[LLVM] Silence compiler-rt warning in runtimes build#99525
Conversation
Summary: The `compiler-rt` project wants `LLVM_CMAKE_DIR` but the `llvm_ExternalProject_add` interface sets the `LLVM_CONFIG_PATH`. This patch just makes the utility pass that as well.
compnerd
left a comment
There was a problem hiding this comment.
How do LLVM_CONFIG_PATH and LLVM_CMAKE_PATH interact? If they don't then, we should be good.
Not sure myself, they seem to just point to different things and |
It seems that they do interact, with |
Alright, thanks for the fast review. While you're here, I need to get the The next step would be adding logic for executing the tests under an "emulator", i.e. |
revert: [LLVM] Silence compiler-rt warning in runtimes build (llvm#99525) revert: 72ff049 [ValueTracking] Consistently propagate `DemandedElts` is `isKnownNonZero` Change-Id: Ifb72990d2870037f00d502a0ccbd1bebef7cb1d7
Summary: The `compiler-rt` project wants `LLVM_CMAKE_DIR` but the `llvm_ExternalProject_add` interface sets the `LLVM_CONFIG_PATH`. This patch just makes the utility pass that as well. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250949
Summary: This patch broke LLVM Flang build on Windows. PR #100202 This reverts commit f6f88f4. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250542
)" This patch broke LLVM Flang build on Windows. PR llvm#100202 This reverts commit f6f88f4. (cherry picked from commit 73d862e)
)" This patch broke LLVM Flang build on Windows. PR llvm#100202 This reverts commit f6f88f4. (cherry picked from commit 73d862e)
Summary:
The
compiler-rtproject wantsLLVM_CMAKE_DIRbut thellvm_ExternalProject_addinterface sets theLLVM_CONFIG_PATH. Thispatch just makes the utility pass that as well.