[Test][compiler-rt]Require lld for instrprof-vtable-value-prof.cpp #97228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-pgo Author: Mingming Liu (minglotus-6) ChangesFix test failure on https://lab.llvm.org/buildbot/#/builders/95/builds/672
Tested:
[1] https://lab.llvm.org/buildbot/#/builders/95/builds/672/steps/4/logs/stdio Full diff: https://github.com/llvm/llvm-project/pull/97228.diff 1 Files Affected:
diff --git a/compiler-rt/test/profile/Linux/instrprof-vtable-value-prof.cpp b/compiler-rt/test/profile/Linux/instrprof-vtable-value-prof.cpp
index 6cf73c6fdbd73..efb24751da5ff 100644
--- a/compiler-rt/test/profile/Linux/instrprof-vtable-value-prof.cpp
+++ b/compiler-rt/test/profile/Linux/instrprof-vtable-value-prof.cpp
@@ -1,4 +1,4 @@
-// REQUIRES: lld-available
+// REQUIRES: lld, lld-available
// Building the instrumented binary will fail because lld doesn't support
// big-endian ELF for PPC (aka ABI 1).
|
MaskRay
approved these changes
Jun 30, 2024
lravenclaw
pushed a commit
to lravenclaw/llvm-project
that referenced
this pull request
Jul 3, 2024
…lvm#97228) Fix test failure on https://lab.llvm.org/buildbot/#/builders/95/builds/672 * lld project is disabled on that build bot [1] and external lld `/home/buildbots/llvm-external-buildbots/clang.16.0.1/bin/ld.lld` is used to run the test [2]. It doesn't know new options like `-enable-vtable-value-profiling` (which was introduced in llvm@1351d17) * Update test to require `lld` and `lld-available`. Tested: 1. By disabling lld in the project and using old `lld` installed previously[3], I can reproduce the failure. 2. With `requires: lld`, the test become unsupported. [1] https://lab.llvm.org/buildbot/#/builders/95/builds/672/steps/4/logs/stdio [2] https://lab.llvm.org/buildbot/#/builders/95/builds/672/steps/6/logs/FAIL__Profile-powerpc64le__instrprof-vtable-value- [3] `cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_PROJECTS='clang;compiler-rt' -DLLVM_USE_SPLIT_DWARF=On -DLLVM_USE_LINKER=lld -DLLVM_ENABLE_SPHINX=ON -DLLVM_OPTIMIZED_TABLEGEN=TRUE -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_ZLIB=1 ../llvm`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test failure on https://lab.llvm.org/buildbot/#/builders/95/builds/672
/home/buildbots/llvm-external-buildbots/clang.16.0.1/bin/ld.lldis used to run the test [2]. It doesn't know new options like-enable-vtable-value-profiling(which was introduced in 1351d17)lldandlld-available.Tested:
lldinstalled previously[3], I can reproduce the failure.requires: lld, the test become unsupported.[1] https://lab.llvm.org/buildbot/#/builders/95/builds/672/steps/4/logs/stdio
[2] https://lab.llvm.org/buildbot/#/builders/95/builds/672/steps/6/logs/FAIL__Profile-powerpc64le__instrprof-vtable-value-
[3]
cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_PROJECTS='clang;compiler-rt' -DLLVM_USE_SPLIT_DWARF=On -DLLVM_USE_LINKER=lld -DLLVM_ENABLE_SPHINX=ON -DLLVM_OPTIMIZED_TABLEGEN=TRUE -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_ZLIB=1 ../llvm