Skip to content

[NFC][Clang][OMPX] Fix a typo in OMP.td #96398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Conversation

shiltian
Copy link
Contributor

No description provided.

@llvmbot llvmbot added flang:openmp clang:openmp OpenMP related changes to Clang labels Jun 22, 2024
@shiltian shiltian requested review from jdoerfert and jhuber6 June 22, 2024 15:44
@llvmbot
Copy link
Member

llvmbot commented Jun 22, 2024

@llvm/pr-subscribers-flang-openmp

Author: Shilei Tian (shiltian)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/96398.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Frontend/OpenMP/OMP.td (+2-2)
diff --git a/llvm/include/llvm/Frontend/OpenMP/OMP.td b/llvm/include/llvm/Frontend/OpenMP/OMP.td
index dcb4608b687d7..c818448d3d190 100644
--- a/llvm/include/llvm/Frontend/OpenMP/OMP.td
+++ b/llvm/include/llvm/Frontend/OpenMP/OMP.td
@@ -303,7 +303,7 @@ def OMPC_NumThreads : Clause<"num_threads"> {
 def OMPC_OMPX_Attribute : Clause<"ompx_attribute"> {
   let clangClass = "OMPXAttributeClause";
 }
-def OMPC_OMX_Bare : Clause<"ompx_bare"> {
+def OMPC_OMPX_Bare : Clause<"ompx_bare"> {
   let clangClass = "OMPXBareClause";
 }
 def OMPC_OMPX_DynCGroupMem : Clause<"ompx_dyn_cgroup_mem"> {
@@ -2026,7 +2026,7 @@ def OMP_TargetTeams : Directive<"target teams"> {
     VersionedClause<OMPC_NoWait>,
     VersionedClause<OMPC_NumTeams>,
     VersionedClause<OMPC_OMPX_DynCGroupMem>,
-    VersionedClause<OMPC_OMX_Bare>,
+    VersionedClause<OMPC_OMPX_Bare>,
     VersionedClause<OMPC_ThreadLimit>,
   ];
   let leafConstructs = [OMP_Target, OMP_Teams];

@shiltian shiltian merged commit fc23564 into llvm:main Jun 22, 2024
10 checks passed
@shiltian shiltian deleted the omx-typo branch June 22, 2024 19:38
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jun 22, 2024

LLVM Buildbot has detected a new failure on builder lldb-arm-ubuntu running on linaro-lldb-arm-ubuntu while building llvm at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/391

Here is the relevant piece of the build log for the reference:

Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: python_api/sbvalue_synthetic/TestSBValueSynthetic.py (1054 of 2732)
PASS: lldb-api :: python_api/sbvalue_const_addrof/TestSBValueConstAddrOf.py (1055 of 2732)
PASS: lldb-api :: python_api/sbvalue_persist/TestSBValuePersist.py (1056 of 2732)
PASS: lldb-api :: python_api/section/TestSectionAPI.py (1057 of 2732)
PASS: lldb-api :: python_api/signals/TestSignalsAPI.py (1058 of 2732)
PASS: lldb-api :: python_api/sbvalue_unsigned_enum_bitfield_value/TestSBValueUnsignedEnumBitField.py (1059 of 2732)
UNSUPPORTED: lldb-api :: python_api/target-arch-from-module/TestTargetArchFromModule.py (1060 of 2732)
PASS: lldb-api :: python_api/symbol-context/TestSymbolContext.py (1061 of 2732)
PASS: lldb-api :: python_api/symbol-context/two-files/TestSymbolContextTwoFiles.py (1062 of 2732)
UNRESOLVED: lldb-api :: python_api/thread/TestThreadAPI.py (1063 of 2732)
******************** TEST 'lldb-api :: python_api/thread/TestThreadAPI.py' FAILED ********************
Script:
--
/usr/bin/python3.8 /home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env ARCHIVER=/usr/local/bin/llvm-ar --env OBJCOPY=/usr/bin/llvm-objcopy --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin --arch armv8l --build-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/dsymutil --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./lib /home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/python_api/thread -p TestThreadAPI.py
--
Exit Code: -6

Command Output (stdout):
--
lldb version 19.0.0git (https://github.com/llvm/llvm-project.git revision fc23564c44f3eff1847462253d43c08b85489148)
  clang revision fc23564c44f3eff1847462253d43c08b85489148
  llvm revision fc23564c44f3eff1847462253d43c08b85489148

--
Command Output (stderr):
--
python3.8: ../llvm-project/llvm/include/llvm/ADT/SmallVector.h:754: iterator llvm::SmallVectorImpl<std::pair<std::weak_ptr<lldb_private::Listener>, unsigned int>>::erase(const_iterator) [T = std::pair<std::weak_ptr<lldb_private::Listener>, unsigned int>]: Assertion `this->isReferenceToStorage(CI) && "Iterator to erase is out of bounds."' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
#0 0xedabc0d4 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lib/python3.8/site-packages/lldb/_lldb.cpython-38-arm-linux-gnueabihf.so+0xf660d4)
#1 0xedab9af4 llvm::sys::RunSignalHandlers() (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lib/python3.8/site-packages/lldb/_lldb.cpython-38-arm-linux-gnueabihf.so+0xf63af4)
#2 0xedabc96c SignalHandler(int) (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lib/python3.8/site-packages/lldb/_lldb.cpython-38-arm-linux-gnueabihf.so+0xf6696c)
#3 0xf7bf9530 __default_sa_restorer /build/glibc-tftl1u/glibc-2.31/signal/../sysdeps/unix/sysv/linux/arm/sigrestorer.S:67:0
#4 0xf7be97e6 /build/glibc-tftl1u/glibc-2.31/csu/../sysdeps/unix/sysv/linux/arm/libc-do-syscall.S:47:0
#5 0xf7bf87fe raise /build/glibc-tftl1u/glibc-2.31/signal/../sysdeps/unix/sysv/linux/raise.c:28:1

--

********************
PASS: lldb-api :: python_api/type/TestTypeList.py (1064 of 2732)
PASS: lldb-api :: python_api/value/TestValueAPI.py (1065 of 2732)
PASS: lldb-api :: python_api/value/addr_of_void_star/TestValueAPIAddressOfVoidStar.py (1066 of 2732)
UNSUPPORTED: lldb-api :: python_api/value/change_values/libcxx/atomic/TestChangeValue.py (1067 of 2732)
PASS: lldb-api :: python_api/value/change_values/TestChangeValueAPI.py (1068 of 2732)
UNSUPPORTED: lldb-api :: python_api/value/change_values/libcxx/map/TestChangeMapValue.py (1069 of 2732)
PASS: lldb-api :: python_api/value/linked_list/TestValueAPILinkedList.py (1070 of 2732)
PASS: lldb-api :: python_api/value/empty_class/TestValueAPIEmptyClass.py (1071 of 2732)
PASS: lldb-api :: python_api/was_interrupted/TestDebuggerInterruption.py (1072 of 2732)
PASS: lldb-api :: python_api/target/TestTargetAPI.py (1073 of 2732)
PASS: lldb-api :: python_api/value_var_update/TestValueVarUpdate.py (1074 of 2732)

AlexisPerry pushed a commit to llvm-project-tlp/llvm-project that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:openmp OpenMP related changes to Clang flang:openmp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants