[libc++] Properly define _LIBCPP_HAS_NO_UNICODE in __config_site

[ldionne]

Fixes #93638

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

Fixes #93638

---

Full diff: https://github.com/llvm/llvm-project/pull/95138.diff

1 Files Affected:

• (modified) libcxx/include/__config_site.in (+1)

diff --git a/libcxx/include/__config_site.in b/libcxx/include/__config_site.in
index 89a14609ee3f9..67022146c9082 100644
--- a/libcxx/include/__config_site.in
+++ b/libcxx/include/__config_site.in
@@ -26,6 +26,7 @@
 #cmakedefine _LIBCPP_HAS_NO_FILESYSTEM
 #cmakedefine _LIBCPP_HAS_NO_RANDOM_DEVICE
 #cmakedefine _LIBCPP_HAS_NO_LOCALIZATION
+#cmakedefine _LIBCPP_HAS_NO_UNICODE
 #cmakedefine _LIBCPP_HAS_NO_WIDE_CHARACTERS
 #cmakedefine _LIBCPP_HAS_NO_STD_MODULES
 #cmakedefine _LIBCPP_HAS_NO_TIME_ZONE_DATABASE

[mordante]

Thanks! LGTM!

[ldionne]

@mordante , I am getting CI failures in

libcxx/test/libcxx/clang_tidy.gen.py
libcxx/test/libcxx/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/vprint_unicode.pass.cpp
libcxx/test/libcxx/input.output/iostream.format/print.fun/transcoding.pass.cpp
libcxx/test/libcxx/input.output/iostream.format/print.fun/vprint_unicode_posix.pass.cpp
libcxx/test/libcxx/input.output/iostream.format/print.fun/vprint_unicode_windows.pass.cpp
libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp
libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp
libcxx/test/libcxx/utilities/format/format.string/format.string.std/extended_grapheme_cluster.pass.cpp
libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/locale-specific_form.pass.cpp
libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/vprint_unicode.pass.cpp
libcxx/test/std/input.output/iostream.format/print.fun/no_file_description.pass.cpp
libcxx/test/std/input.output/iostream.format/print.fun/vprint_unicode.sh.cpp
libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.char.fsigned-char.pass.cpp
libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.char.funsigned-char.pass.cpp

However, I am really not certain how to best fix those in most cases. Since this is more your cup of tea, do you think you could take a look? I suspect you'll know what the right fixes are right away.

[mordante]

From a quick look this looks like broken tests due to TEST_HAS_NO_UNICODE was never set. I'll create a commit with fixes.

[mordante]

Still LGTM!