[mlir][python] Fix attribute registration in ir.py

[eospadov]

This PR fixes attribute registration for SI8Attr and UI8Attr in ir.py.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Egor Ospadov (eospadov)

Changes

This PR fixes attribute registration for SI8Attr and UI8Attr in ir.py.

---

Full diff: https://github.com/llvm/llvm-project/pull/94615.diff

1 Files Affected:

• (modified) mlir/python/mlir/ir.py (+2-2)

diff --git a/mlir/python/mlir/ir.py b/mlir/python/mlir/ir.py
index 80c965b2d0eb2..a9ac765fe1c17 100644
--- a/mlir/python/mlir/ir.py
+++ b/mlir/python/mlir/ir.py
@@ -68,7 +68,7 @@ def _si1Attr(x, context):
 
 
 @register_attribute_builder("SI8Attr")
-def _i8Attr(x, context):
+def _si8Attr(x, context):
     return IntegerAttr.get(IntegerType.get_signed(8, context=context), x)
 
 
@@ -93,7 +93,7 @@ def _ui1Attr(x, context):
 
 
 @register_attribute_builder("UI8Attr")
-def _i8Attr(x, context):
+def _ui8Attr(x, context):
     return IntegerAttr.get(IntegerType.get_unsigned(8, context=context), x)
 
 

[github-actions]

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

[makslevental]

I guess you were calling these directly and getting tricked? Because otherwise this doesn't actually change/fix anything for you?

[eospadov]

I guess you were calling these directly and getting tricked? Because otherwise this doesn't actually change/fix anything for you?

Yeah and they also happen to break mypy checks since they're re-defining the same function.

[makslevental]

LGTM

[makslevental]

Do you have merge permissions? If not I can merge when it's ready.

[eospadov]

Do you have merge permissions? If not I can merge when it's ready.

I do not, please go ahead and merge it @makslevental, thank you!

[github-actions]

@eospadov Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!