Skip to content

[NFC][libc++][test][AIX] fix SIMD test XFAIL for clang before 19 #94509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

daltenty
Copy link
Member

@daltenty daltenty commented Jun 5, 2024

058e445 added an XFAIL for this test on AIX because of a backend limitation. That backend limitation
has been resolved by 0295c2a and will be available for clang 19, so we should update the test to
limit the XFAIL to clang versions before that.

@daltenty daltenty requested a review from jakeegan June 5, 2024 17:45
@daltenty daltenty requested a review from a team as a code owner June 5, 2024 17:45
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jun 5, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 5, 2024

@llvm/pr-subscribers-libcxx

Author: David Tenty (daltenty)

Changes

058e445 added an XFAIL for this test on AIX because of a backend limitation. That backend limitation
has been resolved by 0295c2a and will be available for clang 19, so we should update the test to
limit the XFAIL to clang versions before that.


Full diff: https://github.com/llvm/llvm-project/pull/94509.diff

1 Files Affected:

  • (modified) libcxx/test/std/experimental/simd/simd.class/simd_copy.pass.cpp (+2-2)
diff --git a/libcxx/test/std/experimental/simd/simd.class/simd_copy.pass.cpp b/libcxx/test/std/experimental/simd/simd.class/simd_copy.pass.cpp
index 8fcc811f6df3e..7d91ca0eada1d 100644
--- a/libcxx/test/std/experimental/simd/simd.class/simd_copy.pass.cpp
+++ b/libcxx/test/std/experimental/simd/simd.class/simd_copy.pass.cpp
@@ -8,9 +8,9 @@
 
 // UNSUPPORTED: c++03, c++11, c++14
 
-// FIXME: Fatal error with following targets (remove XFAIL when fixed):
+// Older versions of clang may encounter a backend error (see 0295c2ad):
 //   Pass-by-value arguments with alignment greater than register width are not supported.
-// XFAIL: target=powerpc{{.*}}-ibm-aix7.2.5.7
+// XFAIL: target=powerpc{{.*}}-ibm-{{.*}} && (clang-17 || clang-18)
 
 // <experimental/simd>
 //

Copy link
Member

@jakeegan jakeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daltenty daltenty changed the title [NFC][libcxx][AIX] fix SIMD test XFAIL for clang before 19 [NFC][libcxx][test][AIX] fix SIMD test XFAIL for clang before 19 Jun 6, 2024
@daltenty daltenty changed the title [NFC][libcxx][test][AIX] fix SIMD test XFAIL for clang before 19 [NFC][libc++][test][AIX] fix SIMD test XFAIL for clang before 19 Jun 6, 2024
@daltenty daltenty merged commit df16842 into llvm:main Jun 6, 2024
56 checks passed
@daltenty daltenty deleted the daltenty/fix-simd-xfail branch June 6, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants