Skip to content

[Clang] Fix potential null pointer dereferences in Sema::AddInitializerToDecl #94368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[Clang] Fix potential null pointer dereferences in Sema::AddInitializerToDecl #94368

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b6d45de
[Clang] Fix potential null pointer dereferences in Sema::AddInitializ…
smanna12 Jun 4, 2024
14d874c
Fix Clang format errors
smanna12 Jun 4, 2024
fc12420
Address review comments
smanna12 Jun 4, 2024
5b2da66
Fix clang format errors
smanna12 Jun 4, 2024
400d685
Fix lit failure
smanna12 Jun 28, 2024
2b600b5
Remove assert
smanna12 Aug 2, 2024
586c34d
Address review comments
smanna12 Aug 19, 2024
3e983f9
Address clang format issues
smanna12 Aug 19, 2024
9b0236f
Fix code
smanna12 Aug 19, 2024
c9346fb
update patch
smanna12 Aug 19, 2024
ea34dff
Fix test failure
smanna12 Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions clang/lib/Sema/SemaDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13477,8 +13477,7 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr *Init, bool DirectInit) {
}

// WebAssembly tables can't be used to initialise a variable.
if (Init && !Init->getType().isNull() &&
Init->getType()->isWebAssemblyTableType()) {
if (!Init->getType().isNull() && Init->getType()->isWebAssemblyTableType()) {
Diag(Init->getExprLoc(), diag::err_wasm_table_art) << 0;
VDecl->setInvalidDecl();
return;
Expand Down Expand Up @@ -13681,6 +13680,10 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr *Init, bool DirectInit) {
}

Init = Result.getAs<Expr>();

assert((Init || InitSeq.steps().empty()) &&
"Should have a valid initializer or no initialization steps at this point");

IsParenListInit = !InitSeq.steps().empty() &&
InitSeq.step_begin()->Kind ==
InitializationSequence::SK_ParenthesizedListInit;
Expand Down
Loading