Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectionDAG] Mark SelectionDAGISel destructor virtual #94132

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

paperchalice
Copy link
Contributor

No description provided.

@paperchalice paperchalice added the skip-precommit-approval PR for CI feedback, not intended for review label Jun 2, 2024
@paperchalice paperchalice merged commit f63b1d2 into llvm:main Jun 2, 2024
5 of 7 checks passed
@llvmbot llvmbot added the llvm:SelectionDAG SelectionDAGISel as well label Jun 2, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 2, 2024

@llvm/pr-subscribers-llvm-selectiondag

Author: None (paperchalice)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/94132.diff

1 Files Affected:

  • (modified) llvm/include/llvm/CodeGen/SelectionDAGISel.h (+1-1)
diff --git a/llvm/include/llvm/CodeGen/SelectionDAGISel.h b/llvm/include/llvm/CodeGen/SelectionDAGISel.h
index fe655543a4705..4972af927cf1e 100644
--- a/llvm/include/llvm/CodeGen/SelectionDAGISel.h
+++ b/llvm/include/llvm/CodeGen/SelectionDAGISel.h
@@ -78,7 +78,7 @@ class SelectionDAGISel {
 
   explicit SelectionDAGISel(TargetMachine &tm,
                             CodeGenOptLevel OL = CodeGenOptLevel::Default);
-  ~SelectionDAGISel();
+  virtual ~SelectionDAGISel();
 
   const TargetLowering *getTargetLowering() const { return TLI; }
 

@paperchalice paperchalice deleted the vdtor branch June 2, 2024 01:24
@nikic
Copy link
Contributor

nikic commented Jun 2, 2024

Please don't forget to include a PR description justifying the change.

@JOE1994
Copy link
Member

JOE1994 commented Jun 2, 2024

Was there an incident that motivated this change?

@paperchalice
Copy link
Contributor Author

Try to fix #83567 with sanitizer, but it still failed with expensive check. Already reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm:SelectionDAG SelectionDAGISel as well skip-precommit-approval PR for CI feedback, not intended for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants