[mlir][ArmSME] NFC: -force-streaming-compatible-sve rename fixup #93177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-force-streaming-compatible-sve was renamed to -force-streaming-compatible in llvm#92774.
c-rhodes
requested review from
banach-space,
dcaballe and
nicolasvasilache
as code owners
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-sme Author: Cullen Rhodes (c-rhodes) Changes-force-streaming-compatible-sve was renamed to Full diff: https://github.com/llvm/llvm-project/pull/93177.diff 1 Files Affected:
diff --git a/mlir/test/Integration/Dialect/Vector/CPU/ArmSME/test-ssve.mlir b/mlir/test/Integration/Dialect/Vector/CPU/ArmSME/test-ssve.mlir
index f283ed31fe58e..ba61be746aa7a 100644
--- a/mlir/test/Integration/Dialect/Vector/CPU/ArmSME/test-ssve.mlir
+++ b/mlir/test/Integration/Dialect/Vector/CPU/ArmSME/test-ssve.mlir
@@ -2,7 +2,7 @@
// DEFINE: %{compile} = mlir-opt %s -test-lower-to-llvm
// DEFINE: %{run} = %mcr_aarch64_cmd \
// DEFINE: -march=aarch64 -mattr=+sve,+sme \
-// DEFINE: --force-streaming-compatible-sve \
+// DEFINE: -force-streaming-compatible \
// DEFINE: -e %{entry_point} -entry-point-result=i32 \
// DEFINE: -shared-libs=%mlir_runner_utils,%mlir_c_runner_utils
|
| @@ -2,7 +2,7 @@ | |||
| // DEFINE: %{compile} = mlir-opt %s -test-lower-to-llvm | |||
| // DEFINE: %{run} = %mcr_aarch64_cmd \ | |||
| // DEFINE: -march=aarch64 -mattr=+sve,+sme \ | |||
| // DEFINE: --force-streaming-compatible-sve \ | |||
| // DEFINE: -force-streaming-compatible \ | |||
There was a problem hiding this comment.
Why does it need this flag? Is the arm_streaming attribute not propagated to the LLVM IR function?
There was a problem hiding this comment.
I think this is just an old test (that predated the arm_streaming attribute). This can probably be removed now.
There was a problem hiding this comment.
Yeah it's a good point, think this was the first test we added and the function attribute hadn't been wired up yet or something. Updated to remove the flag altogether.
sdesmalen-arm
approved these changes
May 23, 2024
banach-space
approved these changes
May 27, 2024
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Jun 26, 2024
…ba70d3543 Local branch amd-gfx bd7ba70 Merged main:8cdecd4d3aedea7bc5f27d1f69da216100cb2815 into amd-gfx:3efff4af20d0 Remote branch main ea20647 [mlir][ArmSME] NFC: -force-streaming-compatible-sve rename fixup (llvm#93177)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-force-streaming-compatible-sve was renamed in #92774 but this test was missed, no longer required so removing.