Skip to content

[mlir] add arith dialect dep to fix buildbot failure #92585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024

Conversation

j2kun
Copy link
Contributor

@j2kun j2kun commented May 17, 2024

https://lab.llvm.org/buildbot/#/builders/268/builds/14288

undefined reference to `mlir::detail::TypeIDResolver<mlir::arith::ConstantOp, void>::id'

@llvmbot llvmbot added the mlir label May 17, 2024
@llvmbot
Copy link
Member

llvmbot commented May 17, 2024

@llvm/pr-subscribers-mlir

Author: Jeremy Kun (j2kun)

Changes

https://lab.llvm.org/buildbot/#/builders/268/builds/14288

undefined reference to mlir::detail::TypeIDResolver<mlir::arith::ConstantOp, void>::id'`


Full diff: https://github.com/llvm/llvm-project/pull/92585.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/Polynomial/IR/CMakeLists.txt (+1)
diff --git a/mlir/lib/Dialect/Polynomial/IR/CMakeLists.txt b/mlir/lib/Dialect/Polynomial/IR/CMakeLists.txt
index 8fa49555dd59c..975315ff49158 100644
--- a/mlir/lib/Dialect/Polynomial/IR/CMakeLists.txt
+++ b/mlir/lib/Dialect/Polynomial/IR/CMakeLists.txt
@@ -18,6 +18,7 @@ add_mlir_dialect_library(MLIRPolynomialDialect
   MLIRBuiltinAttributesIncGen
 
   LINK_LIBS PUBLIC
+  MLIRArithDialect
   MLIRSupport
   MLIRDialect
   MLIRIR

@j2kun j2kun mentioned this pull request May 17, 2024
@j2kun j2kun requested review from clementval and ftynse May 17, 2024 17:48
Copy link
Contributor

@clementval clementval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j2kun j2kun merged commit e18c483 into llvm:main May 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants