[libc++][z/OS] Fixup two linear_congruential_engine tests

[zibi2]

No description provided.

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: None (zibi2)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/92261.diff

1 Files Affected:

• (modified) libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp (+3)

diff --git a/libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp b/libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp
index 73829071bd958..63a1a8adf4e35 100644
--- a/libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp
+++ b/libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp
@@ -83,7 +83,10 @@ int main(int, char**)
     test<unsigned int>();
     test_ext<unsigned int>();
     test<unsigned long>();
+    // This isn't implemented on platforms without __int128
+#ifndef _LIBCPP_HAS_NO_INT128
     test_ext<unsigned long>();
+#endif
     test<unsigned long long>();
     // This isn't implemented on platforms without __int128
 #ifndef _LIBCPP_HAS_NO_INT128

[muiez]

LGTM

[mordante]

Next time, please wait for code owners to have a chance to review your changes.

Please provide a followup patch to fix this in the proper way.

[mordante]

This is wrong. The code should test for TEST_HAS_NO_INT128.

[zibi2]

This is wrong. The code should test for TEST_HAS_NO_INT128.

Sure, I will do this for existing guards as well.

[ldionne]

@zibi2 Please disable the "hide my email" feature in Github. Otherwise, your commits are being committed under 62662650+zibi2@users.noreply.github.com and we require a valid email address for every commit.

[zibi2]

@zibi2 Please disable the "hide my email" feature in Github. Otherwise, your commits are being committed under 62662650+zibi2@users.noreply.github.com and we require a valid email address for every commit.

Yes, I willl.