Skip to content

[scudo][gwp_asan] Clean up Fuchsia zxtest framework integration #90015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[scudo][gwp_asan] Clean up Fuchsia zxtest framework integration #90015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler-rt/lib/gwp_asan/tests/harness.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

#include <stdarg.h>

#if defined(__Fuchsia__)
#ifdef LIBC_COPT_TEST_USE_ZXTEST
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is removing the only occurrence of "Fuchsia" in this file, I'm wondering if we could leave some breadcrumb comment that ties zxtest back to Fuchsia like you did in libc/test/UnitTest/Test.h, for the benefit of those who don't know what zxtest is

#define ZXTEST_USE_STREAMABLE_MACROS
#include <zxtest/zxtest.h>
namespace testing = zxtest;
Expand Down
2 changes: 1 addition & 1 deletion compiler-rt/lib/scudo/standalone/tests/scudo_unit_test.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

#include "platform.h"

#if SCUDO_FUCHSIA
#ifdef LIBC_COPT_TEST_USE_ZXTEST
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At line 48 too?

#include <zxtest/zxtest.h>
using Test = ::zxtest::Test;
#else
Expand Down
Loading