Apply modernize-use-starts-ends-with on llvm-project #89140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb @llvm/pr-subscribers-clang-tools-extra Author: Nicolas van Kempen (nicovank) ChangesRun I am working on some additions to this check, but they don't seem to flag any additional cases anyway. Full diff: https://github.com/llvm/llvm-project/pull/89140.diff 2 Files Affected:
diff --git a/clang-tools-extra/clang-doc/Representation.cpp b/clang-tools-extra/clang-doc/Representation.cpp
index 84233c36e15d98..2afff2929cf79c 100644
--- a/clang-tools-extra/clang-doc/Representation.cpp
+++ b/clang-tools-extra/clang-doc/Representation.cpp
@@ -380,8 +380,8 @@ ClangDocContext::ClangDocContext(tooling::ExecutionContext *ECtx,
this->SourceRoot = std::string(SourceRootDir);
if (!RepositoryUrl.empty()) {
this->RepositoryUrl = std::string(RepositoryUrl);
- if (!RepositoryUrl.empty() && RepositoryUrl.find("http://") != 0 &&
- RepositoryUrl.find("https://") != 0)
+ if (!RepositoryUrl.empty() && !RepositoryUrl.starts_with("http://") &&
+ !RepositoryUrl.starts_with("https://"))
this->RepositoryUrl->insert(0, "https://");
}
}
diff --git a/llvm/unittests/Support/VirtualFileSystemTest.cpp b/llvm/unittests/Support/VirtualFileSystemTest.cpp
index e9b4ac3d92e1dd..e9fd9671ea6ab5 100644
--- a/llvm/unittests/Support/VirtualFileSystemTest.cpp
+++ b/llvm/unittests/Support/VirtualFileSystemTest.cpp
@@ -101,7 +101,7 @@ class DummyFileSystem : public vfs::FileSystem {
std::map<std::string, vfs::Status>::iterator I;
std::string Path;
bool isInPath(StringRef S) {
- if (Path.size() < S.size() && S.find(Path) == 0) {
+ if (Path.size() < S.size() && S.starts_with(Path)) {
auto LastSep = S.find_last_of('/');
if (LastSep == Path.size() || LastSep == Path.size() - 1)
return true;
|
|
@llvm/pr-subscribers-llvm-support Author: Nicolas van Kempen (nicovank) ChangesRun I am working on some additions to this check, but they don't seem to flag any additional cases anyway. Full diff: https://github.com/llvm/llvm-project/pull/89140.diff 2 Files Affected:
diff --git a/clang-tools-extra/clang-doc/Representation.cpp b/clang-tools-extra/clang-doc/Representation.cpp
index 84233c36e15d98..2afff2929cf79c 100644
--- a/clang-tools-extra/clang-doc/Representation.cpp
+++ b/clang-tools-extra/clang-doc/Representation.cpp
@@ -380,8 +380,8 @@ ClangDocContext::ClangDocContext(tooling::ExecutionContext *ECtx,
this->SourceRoot = std::string(SourceRootDir);
if (!RepositoryUrl.empty()) {
this->RepositoryUrl = std::string(RepositoryUrl);
- if (!RepositoryUrl.empty() && RepositoryUrl.find("http://") != 0 &&
- RepositoryUrl.find("https://") != 0)
+ if (!RepositoryUrl.empty() && !RepositoryUrl.starts_with("http://") &&
+ !RepositoryUrl.starts_with("https://"))
this->RepositoryUrl->insert(0, "https://");
}
}
diff --git a/llvm/unittests/Support/VirtualFileSystemTest.cpp b/llvm/unittests/Support/VirtualFileSystemTest.cpp
index e9b4ac3d92e1dd..e9fd9671ea6ab5 100644
--- a/llvm/unittests/Support/VirtualFileSystemTest.cpp
+++ b/llvm/unittests/Support/VirtualFileSystemTest.cpp
@@ -101,7 +101,7 @@ class DummyFileSystem : public vfs::FileSystem {
std::map<std::string, vfs::Status>::iterator I;
std::string Path;
bool isInPath(StringRef S) {
- if (Path.size() < S.size() && S.find(Path) == 0) {
+ if (Path.size() < S.size() && S.starts_with(Path)) {
auto LastSep = S.find_last_of('/');
if (LastSep == Path.size() || LastSep == Path.size() - 1)
return true;
|
|
|
nicovank
force-pushed
the
apply-modernize-use-starts-ends-with
branch
from
4f28ecc to
2c82316
Compare
|
Added one missed instance due to CMake configuration options. |
|
Maybe @kazutakahirata (or anyone else) can stamp the minor I don't have commit access, feel free to hit merge when everything is in order 👍 . |
aniplcc
pushed a commit
to aniplcc/llvm-project
that referenced
this pull request
Apr 21, 2024
Run `modernize-use-starts-ends-with` on llvm-project. Two instances are
flagged, minor readability improvements, extremely minor performance
improvements.
```
python3 clang-tools-extra/clang-tidy/tool/run-clang-tidy.py \
-clang-tidy-binary="build/bin/clang-tidy" \
-clang-apply-replacements-binary="build/bin/clang-apply-replacements" \
-checks="-*,modernize-use-starts-ends-with" \
-header-filter=".*" \
-fix -format
```
I am working on some additions to this check, but they don't seem to
flag any additional cases anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
modernize-use-starts-ends-withon llvm-project. Two instances are flagged, minor readability improvements, extremely minor performance improvements.I am working on some additions to this check, but they don't seem to flag any additional cases anyway.