Skip to content

[mlir] Slightly optimize bytecode op numbering #88310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[mlir] Slightly optimize bytecode op numbering #88310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions mlir/lib/Bytecode/Writer/IRNumbering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,22 +424,22 @@ void IRNumberingState::number(Operation &op) {
number(result.getType());
}

// Only number the operation's dictionary if it isn't empty.
DictionaryAttr dictAttr = op.getDiscardableAttrDictionary();
// Prior to a version with native property encoding, or when properties are
// not used, we need to number also the merged dictionary containing both the
// inherent and discardable attribute.
if (config.getDesiredBytecodeVersion() <
bytecode::kNativePropertiesEncoding ||
!op.getPropertiesStorage()) {
DictionaryAttr dictAttr;
if (config.getDesiredBytecodeVersion() >= bytecode::kNativePropertiesEncoding)
dictAttr = op.getRawDictionaryAttrs();
else
dictAttr = op.getAttrDictionary();
}
// Only number the operation's dictionary if it isn't empty.
if (!dictAttr.empty())
number(dictAttr);

// Visit the operation properties (if any) to make sure referenced attributes
// are numbered.
if (config.getDesiredBytecodeVersion() >= bytecode::kNativePropertiesEncoding &&
if (config.getDesiredBytecodeVersion() >=
bytecode::kNativePropertiesEncoding &&
op.getPropertiesStorageSize()) {
if (op.isRegistered()) {
// Operation that have properties *must* implement this interface.
Expand Down