Run pre-merge build with -k 0 to ensure all tests runs #84828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -k option allows to continue the build after failures as much as possible. This is useful here because when we run > ninja check-llvm check-clang we would like the clang tests to run even if there is a failure in a llvm tests. Fixes llvm#83371
tstellar
reviewed
Mar 11, 2024
|
It will continue to build all the targets it can build: if there is a test target that can run without libSupport it will get there eventually. But it can't build anything that depends on libSupport. |
|
This seems to have broken the pre-commit CI because the |
cpsughrue
added a commit
that referenced
this pull request
Mar 11, 2024
|
I was satisfied with the green mark for the buildkite test passing and didn't check the log: it didn't run anything... This seems like an issue with our premerge config: it does not run at all when we modify this script! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -k option allows to continue the build after failures as much as possible. This is useful here because when we run
we would like the clang tests to run even if there is a failure in a llvm tests.
Fixes #83371