Skip to content

[Tests][LoopDistribute] Re-adding target triple in a test #82954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

nilanjana87
Copy link
Contributor

This triple was removed earlier to fix build errors because of target-specific cost model. It seems more correct to add target requirement for the test than remove it.

@llvmbot
Copy link
Member

llvmbot commented Feb 26, 2024

@llvm/pr-subscribers-llvm-transforms

Author: Nilanjana Basu (nilanjana87)

Changes

This triple was removed earlier to fix build errors because of target-specific cost model. It seems more correct to add target requirement for the test than remove it.


Full diff: https://github.com/llvm/llvm-project/pull/82954.diff

1 Files Affected:

  • (modified) llvm/test/Transforms/LoopDistribute/basic-with-memchecks.ll (+3)
diff --git a/llvm/test/Transforms/LoopDistribute/basic-with-memchecks.ll b/llvm/test/Transforms/LoopDistribute/basic-with-memchecks.ll
index 2b9f777e9f3b24..97ea2c6708dadf 100644
--- a/llvm/test/Transforms/LoopDistribute/basic-with-memchecks.ll
+++ b/llvm/test/Transforms/LoopDistribute/basic-with-memchecks.ll
@@ -1,3 +1,4 @@
+; REQUIRES: x86-registered-target
 ; RUN: opt -aa-pipeline=basic-aa -passes=loop-distribute -enable-loop-distribute -verify-loop-info -verify-dom-info -S \
 ; RUN:   < %s | FileCheck %s
 
@@ -18,6 +19,7 @@
 ;   }
 
 target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-apple-macosx10.10.0"
 
 @B = common global ptr null, align 8
 @A = common global ptr null, align 8
@@ -77,6 +79,7 @@ entry:
 ; CHECK: for.end:
 
 
+; VECTORIZE: mul <4 x i32>
 ; VECTORIZE: mul <4 x i32>
 ; VECTORIZE-NOT: mul <4 x i32>
 

@nilanjana87 nilanjana87 requested a review from fhahn February 26, 2024 03:36
Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should preserve the original test intention, LGTM, thanks!

@fhahn
Copy link
Contributor

fhahn commented Feb 26, 2024

Please try to shorten the commit title to be more concise, as per https://llvm.org/docs/DeveloperPolicy.html#commit-messages

The title should be concise. Because all commits are emailed to the list with the first line as the subject, long titles are frowned upon. Short titles also look better in git log.

@nilanjana87 nilanjana87 changed the title [Tests][LoopDistribute] Re-adding target triple in a test that was removed earlier to fix build errors [Tests][LoopDistribute] Re-adding target triple in a test that was removed earlier Feb 26, 2024
@nilanjana87 nilanjana87 changed the title [Tests][LoopDistribute] Re-adding target triple in a test that was removed earlier [Tests][LoopDistribute] Re-adding target triple in a test Feb 26, 2024
@nilanjana87 nilanjana87 merged commit 435e75d into llvm:main Feb 26, 2024
nilanjana87 added a commit to swiftlang/llvm-project that referenced this pull request Mar 5, 2024
This test triple was removed earlier to fix build errors. To preserve the original test intention the triple is re-added with an explicit target requirement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants