Skip to content

Reland "[TypeProf][InstrPGO] Introduce raw and instr profile format change for type profiling." #82711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 27, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
0dd267b
[TypeProf]Introduce value type in raw profiles
mingmingl-llvm Feb 14, 2024
a4ec017
undo the changes that don't necessarily bundle with profile format
mingmingl-llvm Feb 14, 2024
9c833bd
fix the alignment of struct
mingmingl-llvm Feb 14, 2024
d56bb34
polish format
mingmingl-llvm Feb 14, 2024
206415c
fix format
mingmingl-llvm Feb 14, 2024
84570cd
resolve review feedback
mingmingl-llvm Feb 15, 2024
0c9ed57
add back one blank line in llvm/include/llvm/ProfileData/InstrProfDat…
mingmingl-llvm Feb 15, 2024
67bbafb
Apply suggestions from code review
mingmingl-llvm Feb 16, 2024
c30a699
return truncated error if any
mingmingl-llvm Feb 16, 2024
393d166
resolve review fee feedback
mingmingl-llvm Feb 21, 2024
744b87f
resolve review feedback
mingmingl-llvm Feb 21, 2024
4786174
Merge branch 'main' into users/minglotus-6/typeprofrawformat
mingmingl-llvm Feb 21, 2024
36541d9
restore __llvm_profile_get_num_vtable, and swap the order of two head…
mingmingl-llvm Feb 21, 2024
c74bde7
llvm/test/tools/llvm-profdata/nocompress.test fails because its raw
mingmingl-llvm Feb 21, 2024
d0757f4
Merge branch 'main' into users/minglotus-6/typeprofrawformat
mingmingl-llvm Feb 21, 2024
a825d2a
port new object file sections and helper functions for non-ELF files
mingmingl-llvm Feb 22, 2024
90bdd0d
undo linker magic on Windows
mingmingl-llvm Feb 23, 2024
8b35f49
run clang-format
mingmingl-llvm Feb 23, 2024
ac0515a
Return const pointer (not pointer) for *Linux.c
mingmingl-llvm Feb 23, 2024
0de9631
#include<stddef.h> for Windows
mingmingl-llvm Feb 23, 2024
13a7e78
run clang-format
mingmingl-llvm Feb 23, 2024
84e702e
fix a type for *Other.c
mingmingl-llvm Feb 23, 2024
51fca4a
Add COMPILER_RT_VISIBLITY to not leak the symbols
mingmingl-llvm Feb 23, 2024
8cad3bd
add comment to explain why InstrProfilingPlatformWindows.c doesn't im…
mingmingl-llvm Feb 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: modiking <modiking213@gmail.com>
  • Loading branch information
mingmingl-llvm and modiking authored Feb 16, 2024
commit 67bbafb8642a1fe4e15159377b7f13b0c0755bce
6 changes: 3 additions & 3 deletions compiler-rt/include/profile/InstrProfData.inc
Original file line number Diff line number Diff line change
Expand Up @@ -210,17 +210,17 @@ VALUE_PROF_KIND(IPVK_MemOPSize, 1, "memory intrinsic functions size")
/* For virtual table address profiling, the address point of the virtual table
* (i.e., the address contained in objects pointing to a virtual table) are
* profiled. Note this may not be the address of the per C++ class virtual table
* object (e.g., there might be an offset).
* object (e.g., there might be an offset).
*
* The profiled addresses are stored in raw profile, together with the following
* two types of information.
* 1. The (starting and ending) addresses of per C++ class virtual table objects.
* 2. The (compressed) virtual table object names.
* RawInstrProfReader converts profiled virtual table addresses to virtual table
* objects' MD5 hash.
* objects' MD5 hash.
*/
VALUE_PROF_KIND(IPVK_VTableTarget, 2, "The address of the compatible vtable (i.e., "
"there is an offset from this address to per C++ "
"there is an offset from this address to a C++ "
"class virtual table global variable.)")
/* These two kinds must be the last to be
* declared. This is to make sure the string
Expand Down