[BOLT][NFC] Propagate BOLTErrors from Core, RewriteInstance, and passes (2/2) #81523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
aaupov
requested review from
ayermolo,
dcci,
maksfb and
rafaelauler
as code owners
aaupov
changed the title
Created using spr 1.3.4
rafaelauler
approved these changes
Feb 12, 2024
Contributor
rafaelauler
left a comment
rafaelauler
left a comment
There was a problem hiding this comment.
Thanks, as commit message:
As part of the effort to refactor old error handling code that
would directly call exit(1), in this patch continue the migration
on libCore, libRewrite and libPasses to use the new BOLTError
class whenever a failure occurs.
Created using spr 1.3.4 [skip ci]
aaupov
changed the base branch from
users/aaupov/spr/main.bolt-propagate-bolterrors-from-core-rewriteinstance-and-passes-2n
to
main
aaupov
changed the title
aaupov
deleted the
users/aaupov/spr/bolt-propagate-bolterrors-from-core-rewriteinstance-and-passes-2n
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the effort to refactor old error handling code that
would directly call exit(1), in this patch continue the migration
on libCore, libRewrite and libPasses to use the new BOLTError
class whenever a failure occurs.
Test Plan: NFC
Co-authored-by: Rafael Auler rafaelauler@fb.com