Do not use PerformEXTRACTCombine for v8i8 types #81242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as with v4i8, we should not be using PerformEXTRACTCombine for v8i8 types.
|
Something odd is going on here. Skipping MVT::v8i8 here should've resulted in lowering extractelement using 64-bit BFE instruction. Yet we're ending with the code splitting 64-bit input it into two 32-bit words and then extracting bytes from each using 32-bit BFE. It's probably a wash performance-wise, as the actual registers are 32-bit, but it suggests we're missing something. We may need to mark the v8i8 extractelement legal. |
Artem-B
approved these changes
Feb 9, 2024
|
Fix for the lowering is in #81308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as with v4i8 types, we should not be using PerformEXTRACTCombine for v8i8 types.