[DWARFLinker][NFC] Move common code into the base library: Utils.h #77604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is extracted from llvm#74725. Put some usefull routines into the common Utils.h.
avl-llvm
requested review from
JDevlieghere,
adrian-prantl and
felipepiovezan
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
felipepiovezan
approved these changes
Jan 10, 2024
| @@ -5,3 +5,5 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| #include "llvm/DWARFLinker/Utils.h" | |||
There was a problem hiding this comment.
Do you intend to add any code to this file? If it's empty, we can delete it
There was a problem hiding this comment.
yes, I am going to add code to this file in the future. Another thing is that currently this is the only .cpp file in the library. Without any .cpp file it would be necessary to write more complex CMakeLists.txt. It is just easier to have empty .cpp.
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
…lvm#77604) This patch is extracted from llvm#74725. Put some usefull routines into the common Utils.h.
felipepiovezan
pushed a commit
to felipepiovezan/llvm-project
that referenced
this pull request
Feb 2, 2024
…lvm#77604) This patch is extracted from llvm#74725. Put some usefull routines into the common Utils.h. (cherry picked from commit a02c0d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is extracted from #74725.
Put some usefull routines into the common Utils.h.