Skip to content

[DWARFLinker][NFC] Move common code into the base library: IndexedValuesMap. #77437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

avl-llvm
Copy link
Collaborator

@avl-llvm avl-llvm commented Jan 9, 2024

This patch is extracted from #74725.
Both dwarflinkers contain similar classes for indexed values. Move the code into the DWARFLinkerBase.

…uesMap.

This patch is extracted from llvm#74725.
Both dwarflinkers contain similar classes for indexed values.
Move the code into the DWARFLinkerBase.
Copy link

github-actions bot commented Jan 9, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@avl-llvm
Copy link
Collaborator Author

friendly ping.

Copy link
Contributor

@felipepiovezan felipepiovezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@avl-llvm
Copy link
Collaborator Author

Thank you for the review!

@avl-llvm avl-llvm merged commit cf799b3 into llvm:main Jan 18, 2024
@avl-llvm avl-llvm deleted the avl-llvm/refactor-dwarflinker-short-2 branch January 18, 2024 17:21
ampandey-1995 pushed a commit to ampandey-1995/llvm-project that referenced this pull request Jan 19, 2024
…uesMap. (llvm#77437)

This patch is extracted from llvm#74725.
Both dwarflinkers contain similar classes for indexed values. Move the
code into the DWARFLinkerBase.
felipepiovezan pushed a commit to felipepiovezan/llvm-project that referenced this pull request Feb 2, 2024
…uesMap. (llvm#77437)

This patch is extracted from llvm#74725.
Both dwarflinkers contain similar classes for indexed values. Move the
code into the DWARFLinkerBase.

(cherry picked from commit cf799b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants