Skip to content

[DebugInfo] Correctly track metadata slots for DPValues #76941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2024
Merged

[DebugInfo] Correctly track metadata slots for DPValues #76941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion llvm/lib/IR/AsmWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,9 @@ class SlotTracker : public AbstractSlotTrackerStorage {

/// Add all of the metadata from an instruction.
void processInstructionMetadata(const Instruction &I);

/// Add all of the metadata from an instruction.
void processDPValueMetadata(const DPValue &DPV);
};

} // end namespace llvm
Expand Down Expand Up @@ -1126,11 +1129,19 @@ void SlotTracker::processGlobalObjectMetadata(const GlobalObject &GO) {
void SlotTracker::processFunctionMetadata(const Function &F) {
processGlobalObjectMetadata(F);
for (auto &BB : F) {
for (auto &I : BB)
for (auto &I : BB) {
for (const DPValue &DPV : I.getDbgValueRange())
processDPValueMetadata(DPV);
processInstructionMetadata(I);
}
}
}

void SlotTracker::processDPValueMetadata(const DPValue &DPV) {
CreateMetadataSlot(DPV.getVariable());
CreateMetadataSlot(DPV.getDebugLoc());
}

void SlotTracker::processInstructionMetadata(const Instruction &I) {
// Process metadata used directly by intrinsics.
if (const CallInst *CI = dyn_cast<CallInst>(&I))
Expand Down