[JITLink][AArch32] Run all error unittests through the main entrypoints applyFixup() and readAddend() #72091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions Reading implicit addend from a relocation site doesn't require a complete LinkGraph edge. It's independent from the TargetSymbol, but constructing an edge instance required one. This patch fixes the inconsistency and simplifies some setup code from the error unittests.
…ts applyFixup() and readAddend() This patch is in preparation for the Arm/Thumb/Data helper functions to be turned into implementation details. Exposing them in the API causes unfortunate inconsistencies that we don't want to error-check all the time, e.g. passing Thumb_Call to readAddendArm().
weliveindetail
changed the title
eymay
approved these changes
Nov 15, 2023
Contributor
eymay
left a comment
eymay
left a comment
There was a problem hiding this comment.
Thanks this removed coupling to Edge. LGTM!
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Nov 20, 2023
…lvm#72091) Reading implicit addend from a relocation site doesn't require a complete `LinkGraph` edge. The operation is independent from `TargetSymbol`, but constructing an `Edge` instance required one. This patch fixes the inconsistency and simplifies some setup code from the error unittests. Furthermore this patch prepares for the `Arm`/`Thumb`/`Data` helper functions to be turned into implementation details. Exposing them in the API causes unfortunate inconsistencies that we don't want to error-check all the time, e.g. passing `Thumb_Call` to `readAddendArm()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit: Reading implicit addend from a relocation site doesn't require a complete
LinkGraphedge. The operation is independent fromTargetSymbol, but constructing anEdgeinstance required one. This patch fixes the inconsistency and simplifies some setup code from the error unittests.The second commit is in preparation for the
Arm/Thumb/Datahelper functions to be turned into implementation details. Exposing them in the API causes unfortunate inconsistencies that we don't want to error-check all the time, e.g. passingThumb_CalltoreadAddendArm().