[flang][OpenMP] Skip default privatization for crashing cases

[NimishMishra]

This patch skips default privatization for crashing cases like namelists, reduction instrinsics, and structure constructor.

Fixes: #67332, #66454, and #65569

Co-Authored-By: kiranchandramohan kiran.chandramohan@arm.com

[llvmbot]

@llvm/pr-subscribers-flang-openmp

@llvm/pr-subscribers-flang-fir-hlfir

Author: None (NimishMishra)

Changes

This patch skips default privatization for crashing cases like namelists, reduction instrinsics, and structure constructor.

Fixes: #67332, #66454, and #65569

Co-Authored-By: kiranchandramohan <kiran.chandramohan@arm.com>

---

Full diff: https://github.com/llvm/llvm-project/pull/71922.diff

1 Files Affected:

• (modified) flang/lib/Lower/OpenMP.cpp (+4-1)

diff --git a/flang/lib/Lower/OpenMP.cpp b/flang/lib/Lower/OpenMP.cpp
index 945066549299d77..60db450d9be1508 100644
--- a/flang/lib/Lower/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP.cpp
@@ -483,7 +483,10 @@ void DataSharingProcessor::defaultPrivatize() {
   for (const Fortran::semantics::Symbol *sym : defaultSymbols) {
     if (!symbolsInNestedRegions.contains(sym) &&
         !symbolsInParentRegions.contains(sym) &&
-        !privatizedSymbols.contains(sym)) {
+        !privatizedSymbols.contains(sym) &&
+        !Fortran::semantics::IsProcedure(*sym) &&
+        !sym->GetUltimate().has<Fortran::semantics::DerivedTypeDetails>() &&
+        !sym->GetUltimate().has<Fortran::semantics::NamelistDetails>()) {
       cloneSymbol(sym);
       copyFirstPrivateSymbol(sym);
     }

[NimishMishra]

Not adding HLFIR tests as of now because the default privatization for parallel do is currently not sound (refer #71915 and #71914). I'll add tests for namelists, structure constructors, and procedures in reduction() in the fix I send across for these issues.

[kiranchandramohan]

LG.

Could you add one test each for these conditions. Just check that the lowering pass, no need to check the IR in detail.

[kiranchandramohan]

Move these checks to the beginning.