Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMDGPU] Call the FINI_ARRAY destructors in the correct order #71815

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[AMDGPU] Call the FINI_ARRAY destructors in the correct order #71815

merged 1 commit into from
Nov 10, 2023

Commits on Nov 9, 2023

  1. [AMDGPU] Call the FINI_ARRAY destructors in the correct order 

    Summary:
The AMDGPU backend uses the linker-provided INIT_ARRAY and FINI_ARRAY
sections to call all the global constructors in a single kernel.
Previously this mistakenly used the same iteration logic for both
arrays. The destructors stored in FINI_ARRAY are actually stored in
reverse order, so we must start at the end of the array and decrement.
This patch makes the neccesarry changes to properly respect priority.
    @jhuber6
    jhuber6 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    bfe320f View commit details
    Browse the repository at this point in the history