Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc][math] Add min/max/min_denorm/max_denorm constants to FPBits and clean up its constants return types. #71298

Merged
merged 3 commits into from
Nov 6, 2023
Merged

[libc][math] Add min/max/min_denorm/max_denorm constants to FPBits and clean up its constants return types. #71298

merged 3 commits into from
Nov 6, 2023

Conversation

lntue
Copy link
Contributor

@lntue lntue commented Nov 4, 2023

No description provided.

@llvmbot llvmbot added the libc label Nov 4, 2023
michaelrj-google
michaelrj-google approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@michaelrj-google michaelrj-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for doing this cleanup.

@lntue lntue merged commit d2361b2 into llvm:main Nov 6, 2023
3 checks passed
@lntue lntue deleted the fmod branch November 6, 2023 23:22
This was referenced Nov 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelrj-google michaelrj-google michaelrj-google approved these changes

@jhuber6 jhuber6 Awaiting requested review from jhuber6

Assignees
No one assigned
Labels
libc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lntue @michaelrj-google @llvmbot