Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set minimal permission on github workflow #69737

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

diogoteles08
Copy link
Contributor

Relates to #69736

Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
Copy link
Collaborator

@tstellar tstellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ldionne
Copy link
Member

ldionne commented Oct 21, 2023

Ahhh, I think what happened is that I copied the clang-format workflow, then saw it had

permissions:
  pull-requests: write

and simply removed it cause I didn't need it. My bad, but thanks for fixing!

@llvmbot
Copy link
Member

llvmbot commented Oct 21, 2023

@llvm/pr-subscribers-github-workflow

Author: Diogo Teles Sant'Anna (diogoteles08)

Changes

Relates to #69736


Full diff: https://github.com/llvm/llvm-project/pull/69737.diff

1 Files Affected:

  • (modified) .github/workflows/libcxx-check-generated-files.yml (+3)
diff --git a/.github/workflows/libcxx-check-generated-files.yml b/.github/workflows/libcxx-check-generated-files.yml
index 6f2d01ee0a56fdb..570055624b2a8d4 100644
--- a/.github/workflows/libcxx-check-generated-files.yml
+++ b/.github/workflows/libcxx-check-generated-files.yml
@@ -4,6 +4,9 @@ on:
     paths:
       - 'libcxx/**'
 
+permissions:
+  contents: read
+
 jobs:
   check_generated_files:
     runs-on: ubuntu-latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants