[clang][dataflow] Rename test target function to target().
#66195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the test doesn't actually do anything.
llvmbot
added
clang
|
@llvm/pr-subscribers-clang ChangesOtherwise, the test doesn't actually do anything.-- 1 Files Affected:
diff --git a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp
index 05ee5df0e95a433..0abd171f1d0b7cb 100644
--- a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp
+++ b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp
@@ -5860,7 +5860,7 @@ TEST(TransferTest, EvaluateBlockWithUnreachablePreds) {
// is marked unreachable). Trying to get the analysis state via
// `getEnvironment` for the subexpression still should not crash.
std::string Code = R"(
- int cast(int i) {
+ int target(int i) {
if ((i < 0 && true) || false) {
return 0;
}
|
martinboehme
added a commit
to martinboehme/llvm-project
that referenced
this pull request
Sep 13, 2023
…target functions. Before, we were silently letting the test pass, which masks test bugs; for an example, see llvm#66195.
kstoimenov
pushed a commit
to kstoimenov/llvm-project
that referenced
this pull request
Sep 14, 2023
…target functions. (llvm#66197) Before, we were silently letting the test pass, which masks test bugs; for an example, see llvm#66195.
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…target functions. (llvm#66197) Before, we were silently letting the test pass, which masks test bugs; for an example, see llvm#66195.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the test doesn't actually do anything.