Skip to content

Conversation

@preames
Copy link
Collaborator

@preames preames commented Sep 11, 2023

A splat index means the operation is reading from (writing to) the same memory location. Generally, zero is the cheapest value to splat. As such, we'd prefer to add the splatted value to the base, and use a constant zero as the index operand.

A splat index means the operation is reading from (writing to) the same memory location.  Generally, zero is the cheapest value to splat.  As such, we'd prefer to add the splatted value to the base, and use a constant zero as the index operand.
@preames preames requested review from a team as code owners September 11, 2023 16:54
@llvmbot llvmbot added the llvm:SelectionDAG SelectionDAGISel as well label Sep 11, 2023
Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@preames preames merged commit 2f005df into llvm:main Sep 13, 2023
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
A splat index means the operation is reading from (writing to) the same
memory location. Generally, zero is the cheapest value to splat. As
such, we'd prefer to add the splatted value to the base, and use a
constant zero as the index operand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants