[llvm-cov] - Output better error message when the error kind is coveragemap_error::malforme.
#65264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaskRay
approved these changes
Sep 4, 2023
MaggieYingYi
force-pushed
the
yingyi/main/llvm-cov
branch
from
521abeb to
35bc124
Compare
MaggieYingYi
force-pushed
the
yingyi/main/llvm-cov
branch
from
35bc124 to
175fe08
Compare
…ragemap_error::malforme`. The current llvm-cov error message for kind `coveragemap_error::malforme`, just gives the issue kind without any reason for what caused the issue. This patch is aimed at improving the llvm-cov error message to help identify what caused the issue. Reviewed By: MaskRay Close: llvm#65264
MaggieYingYi
force-pushed
the
yingyi/main/llvm-cov
branch
from
175fe08 to
ba51300
Compare
|
I'm seeing failures in compiler-rt/test/profile/Linux/binary-id-lookup.c after this patch. Looks like the messages need to be updated in that test as well. See https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8770695790398874177/overview Would you mind taking a look? |
|
Thanks @abrachet, I am fixing it. |
|
Fixed in the commit 61d6154. |
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
…ragemap_error::malforme`. (llvm#65264) The current llvm-cov error message for kind `coveragemap_error::malforme`, just gives the issue kind without any reason for what caused the issue. This patch is aimed at improving the llvm-cov error message to help identify what caused the issue. Reviewed By: MaskRay Close: llvm#65264
whentojump
added a commit
to xlab-uiuc/llvm-mcdc
that referenced
this pull request
Feb 2, 2024
Currently errors returned from CoverageMappingIterator will have their message part discarded. This commit copies that message when constructing the new CoverageMapError object, and let it displayed at the end caller (llvm-cov). Related: llvm#65264
whentojump
added a commit
to xlab-uiuc/llvm-mcdc
that referenced
this pull request
Feb 27, 2024
Currently errors returned from CoverageMappingIterator will have their message part discarded. This commit copies that message when constructing the new CoverageMapError object, and let it displayed at the end caller (llvm-cov). Related: llvm#65264
qihangkong
pushed a commit
to rvgpu/llvm
that referenced
this pull request
Apr 18, 2024
…ragemap_error::malforme`. (#65264) The current llvm-cov error message for kind `coveragemap_error::malforme`, just gives the issue kind without any reason for what caused the issue. This patch is aimed at improving the llvm-cov error message to help identify what caused the issue. Reviewed By: MaskRay Close: llvm/llvm-project#65264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current llvm-cov error message for kind
coveragemap_error::malforme, just gives the issue kind without any reason for what caused the issue. This patch is aimed at improving the llvm-cov error message to help identify what caused the issue.