Skip to content

[lldb][ClangExpressionParser] Clean up ownership of members in ClangDiagnosticManagerAdapter #167731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
+5 −5
Merged

[lldb][ClangExpressionParser] Clean up ownership of members in ClangDiagnosticManagerAdapter #167731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,9 @@ class ClangDiagnosticManagerAdapter : public clang::DiagnosticConsumer {
: m_options(opts), m_filename(filename) {
m_options.ShowPresumedLoc = true;
m_options.ShowLevel = false;
m_os = std::make_shared<llvm::raw_string_ostream>(m_output);
m_os = std::make_unique<llvm::raw_string_ostream>(m_output);
m_passthrough =
std::make_shared<clang::TextDiagnosticPrinter>(*m_os, m_options);
std::make_unique<clang::TextDiagnosticPrinter>(*m_os, m_options);
}

void ResetManager(DiagnosticManager *manager = nullptr) {
Expand Down Expand Up @@ -315,11 +315,11 @@ class ClangDiagnosticManagerAdapter : public clang::DiagnosticConsumer {
private:
DiagnosticManager *m_manager = nullptr;
DiagnosticOptions m_options;
std::shared_ptr<clang::TextDiagnosticPrinter> m_passthrough;
/// Output stream of m_passthrough.
std::shared_ptr<llvm::raw_string_ostream> m_os;
/// Output string filled by m_os.
std::string m_output;
/// Output stream of m_passthrough.
std::unique_ptr<llvm::raw_string_ostream> m_os;
std::unique_ptr<clang::TextDiagnosticPrinter> m_passthrough;
StringRef m_filename;
};

Expand Down
Loading