Skip to content

[libc] Disable overflow test in strfromtest on riscv32 #166719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2025
Merged

[libc] Disable overflow test in strfromtest on riscv32 #166719

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42dc08b
Comment out CharsWrittenOverflow test in strfromtest
mleleszi Nov 6, 2025
ddbd633
Only disable test for riscv 32
mleleszi Nov 6, 2025
ba012cd
Simplify macro def
mleleszi Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libc/test/src/stdlib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ add_header_library(
DEPENDS
libc.src.__support.CPP.type_traits
libc.src.__support.FPUtil.fp_bits
libc.src.__support.macros.properties.architectures
)

add_libc_test(
Expand Down
15 changes: 12 additions & 3 deletions libc/test/src/stdlib/StrfromTest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

#include "src/__support/CPP/type_traits.h"
#include "src/__support/FPUtil/FPBits.h"
#include "src/__support/macros/properties/architectures.h"
#include "test/UnitTest/ErrnoCheckingTest.h"
#include "test/UnitTest/ErrnoSetterMatcher.h"
#include "test/UnitTest/Test.h"
Expand Down Expand Up @@ -495,6 +496,16 @@ class StrfromTest : public LIBC_NAMESPACE::testing::ErrnoCheckingTest {
}
};

// https://github.com/llvm/llvm-project/issues/166795
#ifndef LIBC_TARGET_ARCH_IS_RISCV32
#define STRFROM_OVERFLOW_TEST(name, func) \
TEST_F(LlvmLibc##name##Test, CharsWrittenOverflow) { \
charsWrittenOverflow(func); \
}
#else
#define STRFROM_OVERFLOW_TEST(name, func)
#endif

#define STRFROM_TEST(InputType, name, func) \
using LlvmLibc##name##Test = StrfromTest<InputType>; \
TEST_F(LlvmLibc##name##Test, FloatDecimalFormat) { \
Expand All @@ -514,6 +525,4 @@ class StrfromTest : public LIBC_NAMESPACE::testing::ErrnoCheckingTest {
insufficentBufsize(func); \
} \
TEST_F(LlvmLibc##name##Test, InfAndNanValues) { infNanValues(func); } \
TEST_F(LlvmLibc##name##Test, CharsWrittenOverflow) { \
charsWrittenOverflow(func); \
}
STRFROM_OVERFLOW_TEST(name, func)
Loading