[Compiler-rt] Fix wrong assignment in compiler_rt #164713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
e-kud
reviewed
Oct 22, 2025
compnerd
reviewed
Oct 22, 2025
mikolaj-pirog
requested review from
a team,
aaronmondal,
aaupov,
andykaylor,
ayermolo,
bcardosolopes,
ftynse,
grypp,
keith,
lanza,
maksfb,
makslevental,
nikic,
paschalis-mpeis,
rafaelauler,
rolfmorel,
rupprecht,
stellaraccident,
xlauko,
yota9 and
yozhu
as code owners
mikolaj-pirog
removed request for
aaronmondal,
aaupov,
andykaylor,
ayermolo,
bcardosolopes,
ftynse,
grypp,
lanza,
maksfb,
makslevental,
paschalis-mpeis,
rafaelauler,
xlauko,
yota9 and
yozhu
|
Sorry for accidental ping everyone, I've made a mistake during rebase |
|
My previous approach, to move CWF to Subtypes, is wrong -- these tables have to be in-sync with respective tables in gcc (gcc/common/config/i386/i386-cpuinfo.h). Otherwise, this won't work due to indexes being not synced. As such, I left the |
compnerd
approved these changes
Oct 23, 2025
| }; | ||
|
|
||
| enum ProcessorVendors { | ||
| enum ProcessorVendors : unsigned int { |
There was a problem hiding this comment.
Is this ISO-compliant C? In C17 standard 6.7.2.2 enum-specifier has no enum-base which I am afraid that is only a C++11 feature.
There was a problem hiding this comment.
Ok. enum-type-specifier is a C23 feature and only supported in gcc-13+. Is this : unsigned int important here and can we get rid of it in favor of compatibility with older compilers?
mikolaj-pirog
added a commit
that referenced
this pull request
Oct 26, 2025
…tion (#165048) Typed enums are c23 features and are too new to be used. This PR restores the types in the `__processor_model` struct back to `unsigned int`, removes typed enums, and uses the enum in the function as a variable that's later assigned to a struct in order to prevent errors fixed initially here: #164713 See #165034 for more background
varun-r-mallya
pushed a commit
to varun-r-mallya/llvm-project
that referenced
this pull request
Oct 27, 2025
…tion (llvm#165048) Typed enums are c23 features and are too new to be used. This PR restores the types in the `__processor_model` struct back to `unsigned int`, removes typed enums, and uses the enum in the function as a variable that's later assigned to a struct in order to prevent errors fixed initially here: llvm#164713 See llvm#165034 for more background
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
The `INTEL_CLEARWATERFOREST` belongs to `ProcessorTypes` enum, but it was assigned to `Subtype` value, leading to cpu_specific/cpu_dispatch not recognizing CWF. The type for `Subtype` and `Type` are changed to respective enums to guard against these sort of errors in the future
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
…tion (llvm#165048) Typed enums are c23 features and are too new to be used. This PR restores the types in the `__processor_model` struct back to `unsigned int`, removes typed enums, and uses the enum in the function as a variable that's later assigned to a struct in order to prevent errors fixed initially here: llvm#164713 See llvm#165034 for more background
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
INTEL_CLEARWATERFORESTbelonged toProcessorTypesenum, but it was assigned toSubtypevalue, leading to cpu_specific/cpu_dispatch not recognizing CWF. The type forSubtypeandTypeare changed to respective enums to guard against these sort of errors in the future