[MLIR][Standalone] gate wheel build behind MLIR_ENABLE_BINDINGS_PYTHON=ON #161427
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir Author: Maksim Levental (makslevental) ChangesIf MLIR_ENABLE_BINDINGS_PYTHON=ON then StandalonePythonModules isn't a valid target. Full diff: https://github.com/llvm/llvm-project/pull/161427.diff 2 Files Affected:
diff --git a/mlir/test/Examples/standalone/lit.local.cfg b/mlir/test/Examples/standalone/lit.local.cfg
index ac03503e46ea3..d4ca29c4594ff 100644
--- a/mlir/test/Examples/standalone/lit.local.cfg
+++ b/mlir/test/Examples/standalone/lit.local.cfg
@@ -17,3 +17,5 @@ config.substitutions.append(("%cmake_build_type", config.cmake_build_type))
if not config.llvm_shared_libs_build:
config.available_features.add("non-shared-libs-build")
+if not config.enable_bindings_python:
+ config.available_features.add("bindings-python")
diff --git a/mlir/test/Examples/standalone/test.wheel.toy b/mlir/test/Examples/standalone/test.wheel.toy
index 17d8cb5b246c9..5ff927129793b 100644
--- a/mlir/test/Examples/standalone/test.wheel.toy
+++ b/mlir/test/Examples/standalone/test.wheel.toy
@@ -3,6 +3,7 @@
# C/Users/ContainerAdministrator/AppData/Local/Temp.
# UNSUPPORTED: target={{.*(windows).*}}
# REQUIRES: non-shared-libs-build
+# REQUIRES: bindings-python
# RUN: export CMAKE_BUILD_TYPE=%cmake_build_type
# RUN: export CMAKE_CXX_COMPILER=%host_cxx
|
makslevental
force-pushed
the
users/makslevental/gate-wheel
branch
from
abcd7ba to
13f3e5b
Compare
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/138/builds/19783 Here is the relevant piece of the build log for the reference |
You meant MLIR_ENABLE_BINDINGS_PYTHON=OFF here right? |
|
(thanks for the fix!) |
yes |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
…N=ON (llvm#161427) If MLIR_ENABLE_BINDINGS_PYTHON=ON then [StandalonePythonModules](https://github.com/llvm/llvm-project/blob/main/mlir/examples/standalone/pyproject.toml#L38) isn't a valid target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If MLIR_ENABLE_BINDINGS_PYTHON=ON then StandalonePythonModules isn't a valid target.