Skip to content

Conversation

@jurahul
Copy link
Contributor

@jurahul jurahul commented Sep 19, 2025

Exclude specialized test suites from check-all. Without that, FileCheck and TableGen tests are run twice, and then those that use %t seem to fail

FAIL: LLVM :: TableGen/RuntimeLibcallEmitter-conflict-warning.td (70661 of 87819)
******************** TEST 'LLVM :: TableGen/RuntimeLibcallEmitter-conflict-warning.td' FAILED ********************
Exit Code: 2
********************
PASS: LLVM :: TableGen/RuntimeLibcallEmitter-conflict-warning.td (70665 of 87819

Note: Same test with 2 different numbers, so its run twice and when that happens concurrently, the %t file is shared among the 2 instances causing bad interaction and test failure.

@llvmbot
Copy link
Member

llvmbot commented Sep 19, 2025

@llvm/pr-subscribers-testing-tools

Author: Rahul Joshi (jurahul)

Changes

Exclude specialized test suites from check-all. Without that, FileCheck and TableGen tests are run twice, and then those that use %t seem to fail

FAIL: LLVM :: TableGen/RuntimeLibcallEmitter-conflict-warning.td (70661 of 87819)
******************** TEST 'LLVM :: TableGen/RuntimeLibcallEmitter-conflict-warning.td' FAILED ********************
Exit Code: 2
********************
PASS: LLVM :: TableGen/RuntimeLibcallEmitter-conflict-warning.td (70665 of 87819

Note: Same test with 2 different numbers, so its run twice and when that happens concurrently, the %t file is shared among the 2 instances causing bad interaction and test failure.


Full diff: https://github.com/llvm/llvm-project/pull/159781.diff

2 Files Affected:

  • (modified) llvm/test/FileCheck/CMakeLists.txt (+1)
  • (modified) llvm/test/TableGen/CMakeLists.txt (+1)
diff --git a/llvm/test/FileCheck/CMakeLists.txt b/llvm/test/FileCheck/CMakeLists.txt
index a5bd0daac9b7a..8ff5abf3dd23f 100644
--- a/llvm/test/FileCheck/CMakeLists.txt
+++ b/llvm/test/FileCheck/CMakeLists.txt
@@ -1,4 +1,5 @@
 add_lit_testsuite(check-llvm-filecheck "Running lit suite for FileCheck"
   ${CMAKE_CURRENT_BINARY_DIR}
+  EXCLUDE_FROM_CHECK_ALL
   DEPENDS ${LLVM_TEST_DEPENDS_COMMON}
   )
diff --git a/llvm/test/TableGen/CMakeLists.txt b/llvm/test/TableGen/CMakeLists.txt
index 65774bb4b45b5..99799c726d420 100644
--- a/llvm/test/TableGen/CMakeLists.txt
+++ b/llvm/test/TableGen/CMakeLists.txt
@@ -1,5 +1,6 @@
 add_lit_testsuite(check-llvm-tablegen "Running lit suite for TableGen"
   ${CMAKE_CURRENT_BINARY_DIR}
+  EXCLUDE_FROM_CHECK_ALL
   DEPENDS ${LLVM_TEST_DEPENDS_COMMON}
   DEPENDS llvm-tblgen
   )

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we please land this or revert the original patch quickly to get the bots back to green?

@jurahul jurahul merged commit 8109c3a into llvm:main Sep 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants