Revert "[Clang][CMake] Use IRPGO instead of FE PGO for Cmake Caches (#155957)" #159367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: Paschalis Mpeis (paschalis-mpeis) ChangesThis reverts commit 7fca1f8. Full diff: https://github.com/llvm/llvm-project/pull/159367.diff 1 Files Affected:
diff --git a/clang/cmake/caches/PGO.cmake b/clang/cmake/caches/PGO.cmake
index d6471160037c1..15bc755d110d1 100644
--- a/clang/cmake/caches/PGO.cmake
+++ b/clang/cmake/caches/PGO.cmake
@@ -5,7 +5,7 @@ set(LLVM_ENABLE_PROJECTS "clang;lld" CACHE STRING "")
set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx;libcxxabi;libunwind" CACHE STRING "")
set(LLVM_TARGETS_TO_BUILD Native CACHE STRING "")
-set(BOOTSTRAP_LLVM_BUILD_INSTRUMENTED IR CACHE BOOL "")
+set(BOOTSTRAP_LLVM_BUILD_INSTRUMENTED ON CACHE BOOL "")
set(CLANG_BOOTSTRAP_TARGETS
generate-profdata
stage2
|
boomanaiden154
requested changes
Sep 17, 2025
|
Hey @boomanaiden154, Given that it breaks the On our end, once this is done it will let us move our buildbot to the production buildmaster, which sends emails/commends on similar cases (cc: @gkistanova) |
boomanaiden154
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
The motivation for the revert needs to go in the PR description (which will become the commit description), not a comment.
I'll try and reproduce this locally on a AArch64 machine. If I can't, I'm going to need you to reproduce and send over a profile and maybe some bitcode. I'll reach out if I end up needing anything.
|
Hey @boomanaiden154, Thanks for the quick reply! You are right, I've updated the PR description.
I was able to run without issues with this reversal patch on top of a044d61. Given your approval, should I proceed with the merge? |
Yes. |
paschalis-mpeis
deleted the
users/paschalis-mpeis/revert-irpgo-cmake-cache
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/31325 Here is the relevant piece of the build log for the reference |
kimsh02
pushed a commit
to kimsh02/llvm-project
that referenced
this pull request
Sep 19, 2025
…lvm#155957)" (llvm#159367) This reverts commit 7fca1f8. PR llvm#55957 breaks the BOLT buildbot bolt-aarch64-ubuntu-clang: https://lab.llvm.org/staging/#/builders/126 Example build: https://lab.llvm.org/staging/#/builders/126/builds/2628 > ld.lld: /home/buildbot/workspace/bolt-aarch64-ubuntu-clang/llvm-project/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:10194: bool llvm::LoopVectorizePass::processLoop(llvm::Loop*): Assertion `!verifyFunction(*F, &dbgs())' failed.
itzexpoexpo
pushed a commit
to itzexpoexpo/llvm-project
that referenced
this pull request
Sep 21, 2025
…lvm#155957)" (llvm#159367) This reverts commit 7fca1f8. PR llvm#55957 breaks the BOLT buildbot bolt-aarch64-ubuntu-clang: https://lab.llvm.org/staging/#/builders/126 Example build: https://lab.llvm.org/staging/#/builders/126/builds/2628 > ld.lld: /home/buildbot/workspace/bolt-aarch64-ubuntu-clang/llvm-project/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:10194: bool llvm::LoopVectorizePass::processLoop(llvm::Loop*): Assertion `!verifyFunction(*F, &dbgs())' failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7fca1f8.
PR #55957 breaks the BOLT buildbot bolt-aarch64-ubuntu-clang:
https://lab.llvm.org/staging/#/builders/126
Example build:
https://lab.llvm.org/staging/#/builders/126/builds/2628