[libclc] Add __attribute__((const)) to functions that don't access memory #152456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mory Before this PR, PostOrderFunctionAttrsPass in opt run can deduce memory(none) for these functions. This PR explicitly adds the attribute to align with Clang's OpenCL headers and ensures the attribute is present throughout the compilation flow. Generated bitcode files amdgcn--amdhsa.bc and nvptx64--nvidiacl.bc become slightly smaller.
arsenm
reviewed
Aug 8, 2025
libclc/clc/include/clc/clcfunc.h
Outdated
| #define _CLC_OVERLOAD __attribute__((overloadable)) | ||
| #define _CLC_DECL | ||
| #define _CLC_INLINE __attribute__((always_inline)) inline | ||
| #define _CLC_CNFN __attribute__((const)) |
There was a problem hiding this comment.
Use a less inscrutable abbreviation?
There was a problem hiding this comment.
Use a less inscrutable abbreviation?
done, changed to _CLC_CONST
arsenm
approved these changes
Aug 12, 2025
frasercrmck
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, PostOrderFunctionAttrsPass in opt run can deduce memory(none) for these functions.
This PR explicitly adds the attribute to align with Clang's OpenCL headers and ensures the attribute is present throughout the compilation flow. Generated bitcode files amdgcn--amdhsa.bc and nvptx64--nvidiacl.bc become slightly smaller.