Skip to content

Conversation

@DanBlackwell
Copy link
Contributor

There is an issue tracking lsan incompatibility on these platforms: #131678. Many of these tests are currently failing and creating CI noise.

rdar://157252316

@llvmbot
Copy link
Member

llvmbot commented Aug 4, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Dan Blackwell (DanBlackwell)

Changes

There is an issue tracking lsan incompatibility on these platforms: #131678. Many of these tests are currently failing and creating CI noise.

rdar://157252316


Full diff: https://github.com/llvm/llvm-project/pull/151929.diff

1 Files Affected:

  • (modified) compiler-rt/test/sanitizer_common/CMakeLists.txt (+1-1)
diff --git a/compiler-rt/test/sanitizer_common/CMakeLists.txt b/compiler-rt/test/sanitizer_common/CMakeLists.txt
index 615666676f57a..e455092a98875 100644
--- a/compiler-rt/test/sanitizer_common/CMakeLists.txt
+++ b/compiler-rt/test/sanitizer_common/CMakeLists.txt
@@ -91,7 +91,7 @@ foreach(tool ${SUPPORTED_TOOLS})
     # so don't run the tests by default.
     if (NOT (CMAKE_SYSTEM_NAME MATCHES "Darwin" AND
              ${tool} STREQUAL "lsan" AND
-             ${arch} STREQUAL "i386"))
+             (${arch} STREQUAL "i386" OR ${arch} MATCHES "arm64")))
       list(APPEND SANITIZER_COMMON_TESTSUITES
            ${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME})
     endif()

@yln yln self-requested a review August 4, 2025 17:22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add comment referencing the issue you mentioned: #131678

I think this would be useful in both directions:

  • Folks reading this code can lookup the explanation for disablement
  • If the issue is fixed, having a breadcrumb here increases the chance that these tests are re-enabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done!

There is an issue tracking lsan incompatibility on these platforms: llvm#131678. Many of these tests are currently failing and creating CI noise.
@DanBlackwell DanBlackwell force-pushed the disable-san-common-lsan-tests-apple branch from 0b9a011 to ecb227a Compare August 5, 2025 11:08
@Xazax-hun Xazax-hun merged commit b24ad98 into llvm:main Aug 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants