[opt-viewer] Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually… #151845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraj
added a commit
to kraj/llvm-project
that referenced
this pull request
Aug 3, 2025
… from the CMake Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES so that if the user specifies the variable on the commandline it takes precedence. If not, fall back to the old logic Upstream-Status: Submitted [llvm#151845] Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
Note that the opt-viewer script is always installed anyway, even if the dependencies are not present. I'd say the same variable should be used to seed whether opt-viewer is installed or not. |
kraj
added a commit
to kraj/llvm-project
that referenced
this pull request
Aug 5, 2025
…he CMake Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES so that if the user specifies the variable on the commandline it takes precedence. If not, fall back to the old logic Upstream-Status: Submitted [llvm#151845] Signed-off-by: Khem Raj <raj.khem@gmail.com>
…he CMake Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES so that if the user specifies the variable on the commandline it takes precedence. If not, fall back to the old logic Do not install opt-viewer of the modules are not found. Since the python scripts have dependencies on these modules, it makes not much point to have them installed.
|
I know that LLVM currently has all the detection logic embedded in AddLLVM.cmake, is that by design or just how it's happened? It feels like it could be moved into llvm/tools/opt-viewer/CMakeLists.txt which would then also automatically not run if LLVM_TOOL_OPT_VIEWER_BUILD was OFF. |
kraj
added a commit
to kraj/llvm-project
that referenced
this pull request
Aug 5, 2025
… from the CMake Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES so that if the user specifies the variable on the commandline it takes precedence. If not, fall back to the old logic Upstream-Status: Submitted [llvm#151845] Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
added a commit
to kraj/llvm-project
that referenced
this pull request
Aug 5, 2025
…he CMake Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES so that if the user specifies the variable on the commandline it takes precedence. If not, fall back to the old logic Upstream-Status: Submitted [llvm#151845] Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
added a commit
to kraj/llvm-project
that referenced
this pull request
Aug 6, 2025
…he CMake Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES so that if the user specifies the variable on the commandline it takes precedence. If not, fall back to the old logic Upstream-Status: Submitted [llvm#151845] Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
added a commit
to kraj/llvm-project
that referenced
this pull request
Aug 6, 2025
…he CMake Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES so that if the user specifies the variable on the commandline it takes precedence. If not, fall back to the old logic Upstream-Status: Submitted [llvm#151845] Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… from the CMake
Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES so that if the user specifies the variable on the commandline it takes precedence. If not, fall back to the old logic